Skip to content

Lowercaseit#196

Open
austin-carnahan wants to merge 5 commits into
kscanne:masterfrom
austin-carnahan:lowercaseit
Open

Lowercaseit#196
austin-carnahan wants to merge 5 commits into
kscanne:masterfrom
austin-carnahan:lowercaseit

Conversation

@austin-carnahan

Copy link
Copy Markdown

No description provided.

@b-sai b-sai left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how the script runs without using for loops, makes it readable and clear. However, more test cases are not included as per directions on canvas. Another minor point is that the lowercasing for ga is supposed to work for any variant of ga. Ditto for all other languages. But otherwise great stuff!

Comment thread S23/austin-carnahan/to_lower.py
Comment thread S23/austin-carnahan/to_lower.py
Comment thread S23/austin-carnahan/to_lower.py Outdated
@austin-carnahan

Copy link
Copy Markdown
Author

I like how the script runs without using for loops, makes it readable and clear. However, more test cases are not included as per directions on canvas. Another minor point is that the lowercasing for ga is supposed to work for any variant of ga. Ditto for all other languages. But otherwise great stuff!

@austin-carnahan

Copy link
Copy Markdown
Author

Thanks for the review! I fixed the parts of the code that were missing use cases - especially the Irish languages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants