ci: converge with private sibling + clear deuce clippy debt#59
Open
krukah wants to merge 2 commits into
Open
Conversation
Clears manual_assert_eq debt (24 sites) flagged by pedantic clippy under stable 1.97. Kept in sync with the private sibling repo. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Brings the public CI workflow to parity with the private sibling's shared jobs (the only remaining differences are legitimately rbp-private: the Leptos format job, --features client compile, and docs --exclude client): - pull_request: run on all PRs, not just those targeting main (stricter). - format job renamed "Format" -> "Rust Format" to match. - compile timeout 15 -> 25 min to match. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the public CI workflow to parity with the private sibling's shared jobs, and clears the same
deuceclippy debt.CI parity — the only remaining differences are legitimately private (Leptos format job,
--features clientcompile, docs--exclude client):pull_request: run on all PRs, not just those targetingmain(stricter).Format→Rust Format.timeout-minutes15→25.deuce —
assert!(a == b)→assert_eq!(24 sites), clearingmanual_assert_equnder stable 1.97.mainhas a required status check namedFormat, update it toRust Formator the rename will block merges.cargo clippy --workspace --all-features --all-targets -- -D warnings✅cargo test -p deuce✅ ·cargo fmt --check✅🤖 Generated with Claude Code