test(kuhn): guard sampling-distribution normalization#58
Merged
Conversation
Asserts sampling_distribution sums to ~1 across Kuhn infosets. Fails on the pre-#57 code (Z ≈ 1.04 for J|Bet), where the per-edge smoothing pseudocount and curiosity floor left the distribution unnormalized; passes with the normalized sampling. Locks in the #53 fix. Co-authored-by: andyafter <3354145+andyafter@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression test locking in the #53 fix (PR #57): asserts
sampling_distributionsums to ~1 across all Kuhn infosets.Verified it has teeth — against the pre-#57 code it fails with
sampling_distribution(J, Bet) sums to 1.03786, not 1(the unnormalized Z ≈ 1.04); passes with the normalized sampling.Co-authored with @andyafter, who reported and diagnosed #53.