Skip to content

Fix: public API toggle silently fails to save on auth/CSRF error #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rsimplicio wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: public API toggle silently fails to save on auth/CSRF error #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 28 additions & 14 deletions templates/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4591,21 +4591,35 @@ <h4>Warum Mediastarr anders ist</h4>
let _publicApiState = false;

function togglePublicApi() {
_publicApiState = !_publicApiState;
const tog = document.getElementById('tog-public-api');
const lab = document.getElementById('lab-public-api');
if (tog) tog.className = 'toggle' + (_publicApiState ? ' on' : '');
if (lab) lab.textContent = t(_publicApiState ? 'on' : 'off');
MSLog.info('togglePublicApi →', _publicApiState);
const next = !_publicApiState;
MSLog.info('togglePublicApi →', next);
fetch(BASE + '/api/config', {method:'POST', headers:{'Content-Type':'application/json'},
body: JSON.stringify({public_api_state: _publicApiState})
}).then(r => r.json()).then(d => {
if (d.ok) showActionMessage(
currentLang === 'de'
? (_publicApiState ? '✓ /api/state ist jetzt öffentlich zugänglich (kein Login)' : '✓ /api/state erfordert jetzt Login')
: (_publicApiState ? '✓ /api/state is now publicly accessible (no login)' : '✓ /api/state now requires login'),
_publicApiState ? 'warning' : 'success', 5000);
}).catch(e => MSLog.error('togglePublicApi save failed', e));
body: JSON.stringify({public_api_state: next})
}).then(async r => {
const d = await r.json().catch(() => ({}));
if (r.ok && d.ok) {
_publicApiState = next;
const tog = document.getElementById('tog-public-api');
const lab = document.getElementById('lab-public-api');
if (tog) tog.className = 'toggle' + (_publicApiState ? ' on' : '');
if (lab) lab.textContent = t(_publicApiState ? 'on' : 'off');
showActionMessage(
currentLang === 'de'
? (_publicApiState ? '✓ /api/state ist jetzt öffentlich zugänglich (kein Login)' : '✓ /api/state erfordert jetzt Login')
: (_publicApiState ? '✓ /api/state is now publicly accessible (no login)' : '✓ /api/state now requires login'),
_publicApiState ? 'warning' : 'success', 5000);
} else {
MSLog.error('togglePublicApi save failed', d.error || r.status);
showActionMessage(
currentLang === 'de'
? 'Speichern fehlgeschlagen — bitte neu einloggen und erneut versuchen'
: 'Save failed — please log in again and retry',
'error', 5000);
}
}).catch(e => {
MSLog.error('togglePublicApi save failed', e);
showActionMessage(currentLang === 'de' ? 'Speichern fehlgeschlagen' : 'Save failed', 'error', 5000);
});
}

async function exportConfig() {
Expand Down