Fix unbounded auto-retry loop when retry_max_attempts=0

[Copilot]

shouldRetry treated RetryMaxAttempts <= 0 as "unlimited retries," but retry_max_attempts=0 is a valid config value explicitly meaning "disabled." With auto_check_on_error=true, a repeatedly failing command would recurse infinitely through runSession → retrySession until stack/memory exhaustion.

Changes

• internal/runner/runner.go: Fix shouldRetry condition — replace RetryMaxAttempts <= 0 || RetryCount < RetryMaxAttempts with RetryMaxAttempts > 0 && RetryCount < RetryMaxAttempts so 0 disables auto-retry rather than enabling unbounded retries

// Before — 0 treated as "always retry"
if r.cfg.History.RetryMaxAttempts <= 0 || session.RetryCount < r.cfg.History.RetryMaxAttempts {
    return true
}

// After — 0 means disabled
if r.cfg.History.RetryMaxAttempts > 0 && session.RetryCount < r.cfg.History.RetryMaxAttempts {
    return true
}

• internal/runner/runner_test.go: Add test case asserting shouldRetry returns false when AutoCheckOnError=true but RetryMaxAttempts=0

---

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

[Copilot]

Pull request overview

Fixes an infinite auto-retry recursion when history.retry_max_attempts=0 by treating 0 as “auto-retry disabled” (instead of “unlimited”), preventing runaway runSession → retrySession loops under persistent command failures.

Changes:

• Update Runner.shouldRetry to only auto-retry when RetryMaxAttempts > 0 and the retry count is still below the limit.
• Add a regression test ensuring shouldRetry returns false when AutoCheckOnError=true but RetryMaxAttempts=0.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
internal/runner/runner.go	Corrects auto-retry eligibility logic to prevent unbounded retries when max attempts is configured as 0.
internal/runner/runner_test.go	Adds coverage for the retry_max_attempts=0 disabling behavior to prevent regressions.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.