Polish landing page UI and redesign AppCard layout#31
Merged
Conversation
…iptions - AppCard: make description optional, increase icon size (52px→64px, 1.625rem→2rem) - AppCard: add overflow:hidden to card, add padding-top to footer to fix button overflow - NavBar: add explicit font-family: var(--font-family-base) to ensure consistent font - landing-page: remove descriptions from all dashboard app cards - landing-page + hello-world: set font-family token on body for consistent rendering
… clipping - Move icon and title into a shared horizontal header row (flex row, align-items center) - Remove overflow:hidden from card which was clipping button bottom edge - Reduce card padding (space-6 → space-5) for tighter proportions - Remove .footer wrapper div - button sits directly in card flex column - Shrink icon back to 52px/1.75rem - better proportion without description text below
Without box-sizing: border-box, width: 100% set the content area to 100% of the parent, then horizontal padding was added on top — causing the button to bleed past the right edge of its container (e.g. AppCard).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several UI and code improvements across the landing page, Hello World app, and shared UI library. The main changes focus on visual consistency, improved flexibility for the
AppCardcomponent, and code simplification for application listings.UI Consistency and Visual Improvements:
bodyandNavBaracross both the Hello World and landing page apps, as well as the shared navigation bar. [1] [2] [3]AppCardto improve appearance and responsiveness, including a larger icon, wrapped title row, and ellipsis for overflowed titles. [1] [2] [3]Buttoncomponents usebox-sizing: border-boxfor more predictable sizing.AppCard Component Enhancements:
descriptionprop optional, so cards can be rendered without a description if needed.AppCardlayout to only render the description if provided, and refactored the internal structure for better alignment and flexibility. [1] [2]Code Simplification:
APPSandADMIN_APPSarrays inDashboardPage.jsxby removing thedescriptionfield and using a more concise object structure.