Fix(hello-world-dotnet): fix caddy for new service#27
Merged
Conversation
- Replace custom frontend with @platform/ui-library components (NavBar,
Card, Button) — identical pattern to hello-world-app
- Fix Dockerfile to use monorepo root as build context so ui-library
source is accessible during the React build stage
- Fix docker-compose build context to match (context: ., dockerfile: ...)
- Fix hardcoded JWT_SECRET in docker-compose → use ${JWT_SECRET} env var
- Add hello-world-dotnet-app to CI matrix with root build context
- Add ui-library/** to dotnet path filter so UI changes trigger a rebuild
Caddy was serving stale routing config (no /hello-dotnet/*) because it runs for weeks without restarting and docker compose up -d does not signal it to reload when only the Caddyfile volume content changes. Add a 'caddy reload' step after 'docker compose up -d' so any Caddyfile changes take effect immediately on every deploy.
Docker file bind mounts pin the inode at container start time. When git pull replaces the Caddyfile (new inode), the running Caddy container still sees the old inode via the bind mount, so caddy reload reads stale config. Fix: pipe the Caddyfile content from the host into a temp file inside the container, then reload from that — bypasses the stale bind mount.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.