Remove hardcoded JWT/session secrets from docker-compose#24
Merged
Conversation
…l with env var refs
Copilot
AI
changed the title
[WIP] Fix exposed jwt token in docker compose file
Remove hardcoded JWT and session secrets from docker-compose.yml
May 27, 2026
Copilot
AI
changed the title
Remove hardcoded JWT and session secrets from docker-compose.yml
Remove hardcoded JWT/session secrets from docker-compose
May 27, 2026
krellekrelle
approved these changes
May 27, 2026
krellekrelle
marked this pull request as ready for review
May 27, 2026 15:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A real 64-byte JWT secret and a hardcoded
SESSION_SECRETwere committed directly indocker-compose.yml, exposing them to anyone with repo access.Changes
docker-compose.yml: Replace hardcodedJWT_SECRETacross all 5 services (auth-service,landing-page,hello-world-app,hearts-game-service,training-peaks-service) with${JWT_SECRET}. RemoveSESSION_SECRETentirely — no service reads it at runtime (auth-service uses an internal hardcoded string for its short-lived OAuth state session only)..env.example: DocumentJWT_SECRETas required, with generation instructions (openssl rand -hex 64). Add missingPOSTGRES_DB/USER/PASSWORDvars. DropSESSION_SECRET.The
.envfile is already git-ignored; operators need to create one with a generated secret.