Emit all logs as JSON for logs-ingester compatibility - #35
Merged
Conversation
Route pprof server errors and the server listen error through the slog JSON logger instead of stdlib log/printf-style calls, so every emitted line is a valid JSON object.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the logging approach in
main.goto use the structured logger (slog) instead of the standard library'slogpackage, and improves error reporting for the pprof and main HTTP servers.Logging improvements:
logpackage withlog/slogand removed all usage oflog.Println, switching to the structured logger for consistency and better log formatting.log.Errorwith structured fields, instead of printing them directly.