Add option to pass a proxy - #8
Open
iaincollins wants to merge 1 commit into
Open
Conversation
iaincollins
force-pushed
the
master
branch
2 times, most recently
from
February 25, 2019 15:37
e10816e to
6ae5c32
Compare
If specified the --proxy option is used as a fallback route handler. This can be used to run lambdas and a website under the same hostname/port locally.
krasimir
requested changes
Feb 27, 2019
| * `--config` - path to `now.json` file | ||
| * `--port` - by default the local server listens on port 8004. You can change it via this argument. No newline at end of file | ||
| * `--port` - by default the local server listens on port 8004. You can change it via this argument. | ||
| * `--proxy` - a URL to use as a fallback proxy for requests that would otherwise fail (e.g. `http://localhost:3000`) No newline at end of file |
Owner
There was a problem hiding this comment.
Can you please add one sentence saying that this is not a standard now/zeit feature. It is built here for convenience.
Author
There was a problem hiding this comment.
Thanks for taking a look, will do!
Will add to the read README - let me know if you like the inline help to be more explicit too (was torn between keeping it short and explaining a bit more).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I appreciate this is unsolicited and we haven't discussed it but it was so small I thought I would fork and do the change anyway as I find it useful, then create a PR if you would like to incorporate this change.
Thanks for writing this module! I've found it really useful. I know the Next.js team are working on
next devbut this is super helpful until that ships.I created a repo to show folks how I use
now-lambda-runnerin projects https://serverless-monorepo.now.sh/ … with the--proxyflag this could be even simpler.