Fix HTTP state reconciliation when MQTT is active - #661
Open
dhia-e-rzig wants to merge 1 commit into
Open
Conversation
Owner
|
Hello @dhia-e-rzig, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Appliance.System.Allpolling active when HTTP is the selected protocol, even if an auxiliary MQTT connection is receiving pushesRoot cause
NamespaceHandler.async_poll_all()used_mqtt_activealone to decide that all state updates would arrive by push. With HTTP selected and cloud MQTT connected, a dropped or incomplete multi-channel push therefore disabled the HTTP reconciliation path too. One MSG200 channel could remain stale indefinitely even though a directAppliance.System.Allresponse contained the correct state.The guard now checks both
curr_protocoland_mqtt_active, so HTTP remains the authoritative polling transport while MQTT can still provide low-latency auxiliary pushes.Related context: #538
Tests
pytest tests/test_config_entry.py::test_device_http_poll_with_mqtt_active -qpytest tests/test_config_entry.py -qblack --checkon changed files