Skip to content

Fix Sub Level parameter steps - #3

Merged
kovaacs merged 1 commit into
mainfrom
fix/sub-level-steps
Aug 24, 2026
Merged

Fix Sub Level parameter steps#3
kovaacs merged 1 commit into
mainfrom
fix/sub-level-steps

Conversation

@kovaacs

@kovaacs kovaacs commented Aug 24, 2026

Copy link
Copy Markdown
Owner

Summary

  • expose Melody and Chord Sub Level as the four hardware levels 0 through 3
  • send canonical SysEx values 0, 32, 64, and 96, including modulation
  • document the 2-bit hardware encoding and reject out-of-range saved state

Evidence

Compatibility

Previous saved states with Sub Level values above 3 are intentionally rejected rather than migrated.

Verification

  • cargo fmt --all -- --check
  • cargo clippy --workspace --all-targets --locked -- -D warnings
  • cargo test --workspace --all-targets --locked
  • scripts/validate-bundle.sh (91 passed, 0 failed, 0 warnings, 27 skipped)

Physical hardware validation was not performed for this change.

@kovaacs
kovaacs enabled auto-merge (squash) August 24, 2026 10:51
@kovaacs
kovaacs merged commit 0ff91c2 into main Aug 24, 2026
2 checks passed
@kovaacs
kovaacs deleted the fix/sub-level-steps branch August 24, 2026 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant