Support for 'extra' arguments#3
Draft
jmdacruz wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial attempt at adding support for
extraarguments. For this to work, I had to isolate the code that auto registers the handler in a separate module, so that theexport_stats_on_root_loggerfunction can be called manually with theextraargument (without causing collisions on the prometheus registry).Using
extraarguments on logs can be useful for scenarios such as errors on HTTP requests, where you want to group metrics by status code.Proposed usage (with support for
extra):Proposed usage (without
extra, a.k.a. "classic"):Opens: