feat(components): add Sidebar component (DS-5256)#421
Merged
Conversation
|
Visit the preview URL for this PR (updated for commit af97263): https://react-koobiq-next--prs-421-5u3ie7yy.web.app (expires Tue, 21 Jul 2026 12:59:40 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: fc29847d4a9e5cb1adf458c76a9b681c76e2eeff |
There was a problem hiding this comment.
Pull request overview
This PR introduces a new low-level Sidebar layout component to @koobiq/react-components, including its public API surface, styling, Storybook documentation/examples, and unit tests.
Changes:
- Added
Sidebarcomponent implementation with open/close state (controlled + uncontrolled), sizing, placement, and optional global keyboard shortcut toggle. - Added supporting types/utils/constants, CSS module styling, Vitest + RTL test suite, and Storybook MDX + stories.
- Registered
Sidebarin exports and API extractor/public API guard, and updated the Storybook roadmap entry.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/public_api_guard/components/Sidebar.api.md | New generated API report for the Sidebar public surface. |
| tools/api-extractor/config.json | Included Sidebar in API Extractor component list. |
| packages/components/src/components/Sidebar/utils.ts | Added size normalization + keyboard shortcut / editable-target helpers. |
| packages/components/src/components/Sidebar/types.ts | Added public prop/types definitions for Sidebar. |
| packages/components/src/components/Sidebar/Sidebar.tsx | Added Sidebar component implementation (state, transition, keyboard shortcut). |
| packages/components/src/components/Sidebar/Sidebar.test.tsx | Added unit tests covering state, transitions, sizing, placement, and shortcuts. |
| packages/components/src/components/Sidebar/Sidebar.stories.tsx | Added Storybook stories demonstrating usage patterns and props. |
| packages/components/src/components/Sidebar/Sidebar.module.css | Added CSS module with size transition behavior and placement anchoring. |
| packages/components/src/components/Sidebar/Sidebar.mdx | Added MDX documentation page for Storybook. |
| packages/components/src/components/Sidebar/index.ts | Added component-level barrel exports. |
| packages/components/src/components/Sidebar/constants.ts | Added shared transition timing constants. |
| packages/components/src/components/index.ts | Exported Sidebar from the package components index. |
| .storybook/components/Roadmap/data.ts | Added Sidebar entry to the Storybook roadmap table. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.