Skip to content

chore(deps-dev): uninstall firebase-tools - #193

Merged
artembelik merged 1 commit into
mainfrom
chore/uninstall-firebase-tools
Jul 16, 2026
Merged

chore(deps-dev): uninstall firebase-tools#193
artembelik merged 1 commit into
mainfrom
chore/uninstall-firebase-tools

Conversation

@artembelik

@artembelik artembelik commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Chores
    • Updated preview deployment workflows to use a specific Firebase Hosting action version.
    • Simplified deployment configuration by relying on the action’s default Firebase tooling.
    • Removed the separate Firebase CLI development dependency.

@artembelik artembelik self-assigned this Jul 16, 2026
Copilot AI review requested due to automatic review settings July 16, 2026 12:28
@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Preview deployment workflows now pin the Firebase Hosting deploy action to v0.11.0 and rely on its default Firebase tooling. The standalone firebase-tools development dependency is removed.

Changes

Firebase preview deployment

Layer / File(s) Summary
Align preview deployment tooling
.github/workflows/deploy-preview.yml, .github/workflows/redeploy-preview.yml, package.json
Both preview workflows use FirebaseExtended/action-hosting-deploy@v0.11.0 without an explicit firebaseToolsVersion; firebase-tools is removed from devDependencies.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • koobiq/data-grid#191: Overlaps with the Firebase Hosting action updates in both preview deployment workflows.

Suggested reviewers: lskramarov, nikgurev, copilot

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main change: removing firebase-tools from devDependencies and related workflow pinning.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/uninstall-firebase-tools

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit 99b9f0e):

https://data-grid-next--data-grid-pr-193-kzqxqv9c.web.app

(expires Sun, 19 Jul 2026 12:29:30 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: b9d49913f5b5988e9af8690a8b37f16143707448

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the firebase-tools dev dependency and updates preview-deploy GitHub Actions configuration accordingly, with the goal of relying on FirebaseExtended/action-hosting-deploy rather than a locally-installed Firebase CLI.

Changes:

  • Removed firebase-tools from devDependencies.
  • Updated preview deployment workflows to stop forcing a firebaseToolsVersion and pinned the hosting deploy action to v0.11.0.
  • Regenerated yarn.lock to reflect dependency removal.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
yarn.lock Removes lockfile entries related to firebase-tools and its dependency tree.
package.json Drops firebase-tools from devDependencies.
.github/workflows/redeploy-preview.yml Removes firebaseToolsVersion input from the hosting deploy action.
.github/workflows/deploy-preview.yml Pins FirebaseExtended/action-hosting-deploy to v0.11.0 and removes firebaseToolsVersion.

Comment thread package.json

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/deploy-preview.yml:
- Around line 23-26: Pin the Firebase CLI version in the
FirebaseExtended/action-hosting-deploy step by adding the firebaseToolsVersion
input with the explicitly tested version, rather than relying on the action’s
latest default. Preserve the existing repoToken and firebaseServiceAccount
inputs.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 694cffe1-a4d5-470c-ad00-09cf61ce8bbe

📥 Commits

Reviewing files that changed from the base of the PR and between 02a38cf and 99b9f0e.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (3)
  • .github/workflows/deploy-preview.yml
  • .github/workflows/redeploy-preview.yml
  • package.json
💤 Files with no reviewable changes (2)
  • package.json
  • .github/workflows/redeploy-preview.yml

Comment thread .github/workflows/deploy-preview.yml
@artembelik
artembelik merged commit 3fc3ba3 into main Jul 16, 2026
10 checks passed
@artembelik
artembelik deleted the chore/uninstall-firebase-tools branch July 16, 2026 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants