chore(deps-dev): uninstall firebase-tools - #193
Conversation
📝 WalkthroughWalkthroughPreview deployment workflows now pin the Firebase Hosting deploy action to v0.11.0 and rely on its default Firebase tooling. The standalone ChangesFirebase preview deployment
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Visit the preview URL for this PR (updated for commit 99b9f0e): https://data-grid-next--data-grid-pr-193-kzqxqv9c.web.app (expires Sun, 19 Jul 2026 12:29:30 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: b9d49913f5b5988e9af8690a8b37f16143707448 |
There was a problem hiding this comment.
Pull request overview
Removes the firebase-tools dev dependency and updates preview-deploy GitHub Actions configuration accordingly, with the goal of relying on FirebaseExtended/action-hosting-deploy rather than a locally-installed Firebase CLI.
Changes:
- Removed
firebase-toolsfromdevDependencies. - Updated preview deployment workflows to stop forcing a
firebaseToolsVersionand pinned the hosting deploy action tov0.11.0. - Regenerated
yarn.lockto reflect dependency removal.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| yarn.lock | Removes lockfile entries related to firebase-tools and its dependency tree. |
| package.json | Drops firebase-tools from devDependencies. |
| .github/workflows/redeploy-preview.yml | Removes firebaseToolsVersion input from the hosting deploy action. |
| .github/workflows/deploy-preview.yml | Pins FirebaseExtended/action-hosting-deploy to v0.11.0 and removes firebaseToolsVersion. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/deploy-preview.yml:
- Around line 23-26: Pin the Firebase CLI version in the
FirebaseExtended/action-hosting-deploy step by adding the firebaseToolsVersion
input with the explicitly tested version, rather than relying on the action’s
latest default. Preserve the existing repoToken and firebaseServiceAccount
inputs.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 694cffe1-a4d5-470c-ad00-09cf61ce8bbe
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (3)
.github/workflows/deploy-preview.yml.github/workflows/redeploy-preview.ymlpackage.json
💤 Files with no reviewable changes (2)
- package.json
- .github/workflows/redeploy-preview.yml
Summary by CodeRabbit