feat(actions-panel): added beforeClosed emitter (#DS-5312)#1777
feat(actions-panel): added beforeClosed emitter (#DS-5312)#1777artembelik wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a beforeClosed observable to KbqActionsPanelRef so consumers can react immediately when closing starts (before the exit animation), and updates the Actions Panel docs example to use it for smoother layout/padding transitions.
Changes:
- Expose
KbqActionsPanelRef.beforeClosed: Observable<R | undefined>and emit it synchronously whenclose()is called. - Update the Actions Panel overview example to animate grid padding only while the panel is open, driven by
beforeClosed. - Add unit tests verifying
beforeClosedemission order, result propagation, completion, and single-emission behavior.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tools/public_api_guard/components/actions-panel.api.md | Updates the API snapshot to include the new beforeClosed observable on KbqActionsPanelRef. |
| packages/docs-examples/components/actions-panel/actions-panel-overview/actions-panel-overview-example.ts | Demonstrates using beforeClosed to collapse grid padding in sync with the panel’s exit animation. |
| packages/components/actions-panel/actions-panel.spec.ts | Adds tests covering beforeClosed ordering, result emission, completion, and idempotency. |
| packages/components/actions-panel/actions-panel-ref.ts | Implements beforeClosed as a subject emitted/completed on close() prior to starting the close animation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Visit the preview URL for this PR (updated for commit 9897233): https://koobiq-next--prs-1777-tmg976m0.web.app (expires Sun, 26 Jul 2026 18:29:15 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
@rmnturov обновил главный пример для actions panel, добавил анимацию для появления отступа снизу при открытии панели |
| } | ||
|
|
||
| /** Gets an observable that is notified when the actions panel starts closing, before its exit animation plays. */ | ||
| get beforeClosed(): Observable<R | undefined> { |
There was a problem hiding this comment.
сделано по аналогии с afterClosed (выше реализовано), как предлагаешь сделать?
No description provided.