Skip to content

feat(actions-panel): added beforeClosed emitter (#DS-5312)#1777

Open
artembelik wants to merge 2 commits into
mainfrom
feat/DS-5312
Open

feat(actions-panel): added beforeClosed emitter (#DS-5312)#1777
artembelik wants to merge 2 commits into
mainfrom
feat/DS-5312

Conversation

@artembelik

Copy link
Copy Markdown
Contributor

No description provided.

@artembelik artembelik self-assigned this Jul 23, 2026
Copilot AI review requested due to automatic review settings July 23, 2026 14:42
@artembelik
artembelik requested a review from lskramarov as a code owner July 23, 2026 14:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a beforeClosed observable to KbqActionsPanelRef so consumers can react immediately when closing starts (before the exit animation), and updates the Actions Panel docs example to use it for smoother layout/padding transitions.

Changes:

  • Expose KbqActionsPanelRef.beforeClosed: Observable<R | undefined> and emit it synchronously when close() is called.
  • Update the Actions Panel overview example to animate grid padding only while the panel is open, driven by beforeClosed.
  • Add unit tests verifying beforeClosed emission order, result propagation, completion, and single-emission behavior.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
tools/public_api_guard/components/actions-panel.api.md Updates the API snapshot to include the new beforeClosed observable on KbqActionsPanelRef.
packages/docs-examples/components/actions-panel/actions-panel-overview/actions-panel-overview-example.ts Demonstrates using beforeClosed to collapse grid padding in sync with the panel’s exit animation.
packages/components/actions-panel/actions-panel.spec.ts Adds tests covering beforeClosed ordering, result emission, completion, and idempotency.
packages/components/actions-panel/actions-panel-ref.ts Implements beforeClosed as a subject emitted/completed on close() prior to starting the close animation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit 9897233):

https://koobiq-next--prs-1777-tmg976m0.web.app

(expires Sun, 26 Jul 2026 18:29:15 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@artembelik
artembelik requested a review from rmnturov July 23, 2026 19:06
@artembelik

Copy link
Copy Markdown
Contributor Author

@rmnturov обновил главный пример для actions panel, добавил анимацию для появления отступа снизу при открытии панели

}

/** Gets an observable that is notified when the actions panel starts closing, before its exit animation plays. */
get beforeClosed(): Observable<R | undefined> {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а зчем здесь геттер ?

@artembelik artembelik Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

сделано по аналогии с afterClosed (выше реализовано), как предлагаешь сделать?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants