Update signtool call to use cert thumbprint sha instead of subject - #1017
Open
rhartman93 wants to merge 2 commits into
Open
Update signtool call to use cert thumbprint sha instead of subject#1017rhartman93 wants to merge 2 commits into
rhartman93 wants to merge 2 commits into
Conversation
Contributor
|
/ok-to-test |
Contributor
|
The utils-push-artifacts-to-cdn test should help us assert that this works. But that test wont pass while the account is locked. So we can re-trigger that test when you're ready |
johnbieren
previously approved these changes
Sep 8, 2026
Author
|
unlocked, ok to test
…On Tue, Sep 8, 2026 at 10:53 AM Johnny Bieren ***@***.***> wrote:
***@***.**** approved this pull request.
—
Reply to this email directly, view it on GitHub
<#1017?email_source=notifications&email_token=ABG226MVF7LPTE7A4V6T5DD5OAMNXA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTKMJUGMZTANBVGY4KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#pullrequestreview-5143304568>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABG226M6GTVTEI5IXL7SYA35OAMNXAVCNFSNUABFKJSXA33TNF2G64TZHM2TCOBUGU2TQOBSHNEXG43VMU5TKMZYHAZDCNJUGQYKC5QC>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/ABG226IM6AHSWWIF7ICGVPL5OAMNXA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTKMJUGMZTANBVGY4KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KUZTPN52GK4S7NFXXG>
and Android
<https://github.com/notifications/mobile/android/ABG226N6TO6ENMCBJOLZPB35OAMNXA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTKMJUGMZTANBVGY4KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>.
Download it today!
You are receiving this because you authored the thread.Message ID:
<konflux-ci/release-service-utils/pull/1017/review/5143304568
***@***.***>
|
Update signtool call to use cert thumbprint sha instead of subject Signed-off-by: Ryan Hartman <rhartman@redhat.com>
rhartman93
force-pushed
the
win-sign-use-sha
branch
from
September 8, 2026 15:28
ca586db to
3a368da
Compare
Signed-off-by: Ryan Hartman <rhartman@redhat.com>
Collaborator
|
/ok-to-test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relying on the subject of the signing cert is error prone, if it's wrong, signing fails and our hsm account gets locked out blocking all signing. The subject here is wrong so lets use thumbprint sha instead to unblock signing and increase resiliency