chore: KONFLUX-13929 add pattern references to AGENTS.md - #175
Open
vinashar-rh wants to merge 3 commits into
Open
chore: KONFLUX-13929 add pattern references to AGENTS.md#175vinashar-rh wants to merge 3 commits into
vinashar-rh wants to merge 3 commits into
Conversation
Document common change types with pointers to reference files so agentready pattern_references check passes. Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
|
/ok-to-test |
jhutar
requested changes
Sep 2, 2026
Comment on lines
+30
to
+33
| - New journey stage: see `pkg/journey/handle_pipeline.go` for a reference implementation and `loadtest.go` for wiring into the journey | ||
| - New CLI flag: see `loadtest.go` and `pkg/options/options.go` for flag registration and options struct fields | ||
| - New error pattern: see `ci-scripts/config/errors.yaml` for YAML entry format | ||
| - CSV logging field: see `pkg/logging/time_and_log.go` for column names consumed by `evaluate.py` |
Collaborator
There was a problem hiding this comment.
Given how the repo works (e.g. ci-scripts/config/errors.yaml is managed in different repo, this is just a downstream repo), I suggest these:
Suggested change
| - New journey stage: see `pkg/journey/handle_pipeline.go` for a reference implementation and `loadtest.go` for wiring into the journey | |
| - New CLI flag: see `loadtest.go` and `pkg/options/options.go` for flag registration and options struct fields | |
| - New error pattern: see `ci-scripts/config/errors.yaml` for YAML entry format | |
| - CSV logging field: see `pkg/logging/time_and_log.go` for column names consumed by `evaluate.py` | |
| - New journey stage: see `pkg/journey/handle_pipeline.go` for a reference implementation and `loadtest.go` for wiring into the journey | |
| - Resource create/delete lifecycle: create the resource in a journey handler under | |
| `pkg/journey/` (e.g. `handle_releases_setup.go`, `handle_image_repository.go`) and mirror | |
| the teardown in `handle_purge.go` `Purge()` so cleanup stays idempotent. | |
| - Probe run scripts: shell logic lives in `ci-scripts/run-probe/` (`run.sh`, | |
| `collect-results.sh`, `cluster_read_config.yaml`); mirror changes in the `run-ci/` / | |
| `run-cluster/` variants. | |
| - Horreum data scripts: scripts in `ci-scripts/utility_scripts/` (e.g. | |
| `postgresql-backfill.sh`, `runs-to-csv.sh`) paired with schemas in | |
| `ci-scripts/config/horreum-*.json`. |
vinashar-rh
force-pushed
the
konflux-13929-agentready-pattern-references
branch
from
September 7, 2026 08:37
66973c9 to
5b1d0b0
Compare
Apply jhutar's suggested Pattern References bullets exactly as provided in PR review. Co-authored-by: Cursor <cursoragent@cursor.com>
Strip trailing spaces from pattern reference bullets so pre-commit trim-trailing-whitespace passes in CI. Co-authored-by: Cursor <cursoragent@cursor.com>
Author
|
@jhutar ok ,I implemented the recommended changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AGENTS.mdpointing to real files for common change types (journey stage, CLI flag, error pattern, CSV logging)Test plan
uvx --from git+https://github.com/ambient-code/agentready agentready -- assess .—pattern_referencespassesAGENTS.mdremains under 60 lines (47 lines)Made with Cursor