feat: AI-add optional YAML workflow configuration - #7
Merged
Conversation
komaksym
changed the title
komaksym
changed the title
komaksym
marked this pull request as ready for review
July 2, 2026 20:21
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
komaksym
commented
Jul 2, 2026
| grouped.add_argument( | ||
| "--cluster-method", | ||
| choices=SUPPORTED_CLUSTER_METHODS, | ||
| default="hierarchical", |
Owner
Author
There was a problem hiding this comment.
why is this removed, isn't it still the default?
Comment on lines
+133
to
+145
| class GroupedConfigFile: | ||
| """Validated portable settings loaded from one grouped-workflow YAML file.""" | ||
|
|
||
| dataset_specs: dict[str, DatasetSpec] | ||
| snapshot_column: str = "snapshot" | ||
| timestamp_format: str = DEFAULT_TIMESTAMP_FORMAT | ||
| year: int = 2025 | ||
| countries: tuple[str, ...] | None = None | ||
| working_clusters: int = 5 | ||
| non_working_clusters: int = 2 | ||
| cluster_method: ClusterMethod = "hierarchical" | ||
| non_working_weekdays: frozenset[str] = DEFAULT_NON_WORKING_WEEKDAYS | ||
| preserve_column_means: bool = False |
Owner
Author
There was a problem hiding this comment.
why do we need another config dataclass if we already have one above?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--data-dirusage remains supported.Validation
uv run ruff check src/tsam_workflows tests src/approach_1_ALL.ipynb)uv run mypy src/tsam_workflows)uv run pytest;uv run pytest --nbmake src/approach_1_ALL.ipynb)uv build)Risks / Notes
--data-dircannot be combined with--config; YAML dataset paths resolve relative to the config file.preserve_column_means: trueexports TSAM synthetic mean-preserved representative profiles while retaining medoid dates as provenance.main.Breaking changes