fix: WS-level heartbeat (BRIDGE-9) - #2
Merged
Merged
Conversation
30 s ping/pong on the worker WS. A half-open worker socket (NAT drop, peer crash) delivers neither close nor data; without a ping it is only caught by the 90 s idle timer, during which the callId 409-blocks reconnects (~3x slower recovery). Parity with the Python siblings' aiohttp heartbeat=30. 0.1.0 -> 0.1.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go-live Low finding BRIDGE-9: the Node
wsserver had no ping interval; a half-open worker socket was only reclaimed by the 90 s idle timer (during which the callId 409-blocks reconnects). Add a 30 s ping/pong heartbeat that terminates a dead client next tick. Parity with the Python siblings. 0.1.0 -> 0.1.1.🤖 Generated with Claude Code