Repository navigation
Add batched syr2k - #3348
Merged
Merged
Add batched syr2k#3348
Conversation
yasahi-hpc
force-pushed
the
add-batched-syr2k
branch
from
October 21, 2026 05:16
da63e38 to
4a30d56
Compare
added 3 commits
October 23, 2026 22:04
Signed-off-by: Yuuichi Asahi <y.asahi@nr.titech.ac.jp>
Signed-off-by: Yuuichi Asahi <y.asahi@nr.titech.ac.jp>
Signed-off-by: Yuuichi Asahi <y.asahi@nr.titech.ac.jp>
yasahi-hpc
force-pushed
the
add-batched-syr2k
branch
from
October 23, 2026 20:12
4a30d56 to
88f25ba
Compare
lucbv
approved these changes
Oct 29, 2026
lucbv
left a comment
lucbv
left a comment
Contributor
There was a problem hiding this comment.
This looks fine although could be optimized maybe?
Contributor
There was a problem hiding this comment.
It's a bit annoying that the scaling of c by beta requires a separate loop over all the entries of c before the triple loop over n, k, n
Contributor
Author
There was a problem hiding this comment.
I agree
I just used the reference blas implementation
If you prefer, I can remove if branches for alpha==0 and beta==0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds batched syr2k