Repository navigation
Conversation
dalg24
left a comment
dalg24
left a comment
There was a problem hiding this comment.
Do you want to mention the arXiv paper mentioned in https://kokkos.org/citing-kokkos/#kokkos-kernels ?
|
@brian-kelley @vqd8a @jgfouca @ndellingwood @iyamazaki |
ndellingwood
left a comment
ndellingwood
left a comment
There was a problem hiding this comment.
Thanks @lucbv !
I added a minor rephrasing to consider, feel free to disregard.
I confirmed the orcid's are all valid and match with the name spellings
jgfouca
left a comment
jgfouca
left a comment
There was a problem hiding this comment.
Added AI review to catch spelling and grammar mistakes (if any).
There was a problem hiding this comment.
🟡 Changes recommended
The license value violates the CFF 1.2.0 schema and needs a supported representation.
1 open finding
What changed in this PR
Adds initial citation metadata for Kokkos Kernels so users can cite the software.
Changes:
- Lists authors and contributor identifiers.
- Links the Zenodo concept DOI and project resources.
- Provides a project abstract, keywords, and license metadata.
| File | Description |
|---|---|
| CITATION.cff | Adds software citation metadata and a Zenodo reference. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This points to zenodo and might in the future point to a journal article. The list of authors/contributors are the current members of the team on github. Signed-off-by: Luc Berger-Vergiat <lberge@sandia.gov>
Signed-off-by: Luc Berger-Vergiat <lberge@sandia.gov>
Unfortunate that we cannot state our license in the file but that's not the only place that does not recognize license exceptions : ( Signed-off-by: Luc Berger-Vergiat <lberge@sandia.gov>
63f81dd to
70262a7
Compare
Signed-off-by: Luc Berger-Vergiat <lberge@sandia.gov>
Signed-off-by: Luc Berger-Vergiat <lberge@sandia.gov>
This points to zenodo and might in the future point to a journal article. The list of authors/contributors are the current members of the team on github.