Skip to content

fix invalid type error on systems with HAVE_VA_LIST_AS_ARRAY#340

Open
asmuth wants to merge 1 commit into
kohler:masterfrom
asmuth:master
Open

fix invalid type error on systems with HAVE_VA_LIST_AS_ARRAY#340
asmuth wants to merge 1 commit into
kohler:masterfrom
asmuth:master

Conversation

@asmuth

@asmuth asmuth commented Apr 5, 2017

Copy link
Copy Markdown
Contributor

fixes #336

@kohler

kohler commented Jun 28, 2017

Copy link
Copy Markdown
Owner

I'm confused. Where does HAVE_VA_LIST_AS_ARRAY come from? It's not something we define.

I'm worried that the type error actually represents a problem.

@kohler

kohler commented Jun 28, 2017

Copy link
Copy Markdown
Owner

The CLICK_CHECK_ADDRESSABLE_VA_LIST configury step is supposed to detect this problem, and then leave HAVE_ADDRESSABLE_VA_LIST undefined.

@asmuth

asmuth commented Jun 28, 2017

Copy link
Copy Markdown
Contributor Author

The problem came up a while back when trying to build click inside of a bitbake/yocto toolchain.

I did not realize there was already a check for this condition and added the HAVE_VA_LIST_AS_ARRAY ifdef (which seemed semi-standard, at least mozilla central and rpm use it) as a quick local patch and built with -DHAVE_VA_LIST_AS_ARRAY to work around the issue.

Of course if there already is a proper configure-time check for this, that should be used instead. I'll try debugging later/tomorrow why the CLICK_CHECK_ADDRESSABLE_VA_LIST did not work as intended inside of our cross toolchain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error while cross-compiling clkmindriver

3 participants