Conversation
Integrate VS Code theming
Added symlink management and theme generation steps.
This script installs fish themes by copying necessary files to the fish configuration directory and updating the config.fish file to source them.
Added functions to update fish themes and VSCode theme.
Refactor functions for better type hints and error handling. Update theme generation process and improve logging.
Owner
|
Wow, I will review this tomorrow. I think it's the first pr with more than 10 commits |
Owner
|
What I don't like that you didn't use templates + actions, and you just straight up made whole functions |
Author
|
Are there news on the review? |
Owner
|
I still don't like that you put assets in hypryou/ folder, it's only for code |
Owner
|
Also you put things in wrong directories, didn't use templates, just violating my architecture |
Author
|
I think I now fixed it |
Owner
|
I'd love if you used proper templates generation and looked into how colors work instead of putting these themes as separate layer that makes code a bit bloated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds scripts that add an extension to VS Code/Codium and a theme to fish