Skip to content

add a pull request template and CODEOWNERS - #230

Merged
phanan merged 1 commit into
masterfrom
add-codeowners-and-pr-template
Aug 10, 2026
Merged

add a pull request template and CODEOWNERS#230
phanan merged 1 commit into
masterfrom
add-codeowners-and-pr-template

Conversation

@phanan

@phanan phanan commented Aug 10, 2026

Copy link
Copy Markdown
Member

This repo has issue templates but no pull request template and no CODEOWNERS, so contributor PRs arrive with a bare description and request nobody's review. koel/koel has both; this repo was set up separately and never got them.

CODEOWNERS is * @phanan, matching koel/koel. It requests review automatically on every PR — worth noting it does not populate the Assignees field, which GitHub never fills in on its own; a review request is what drives the notification.

The pull request template follows koel/koel's, with the Screenshots section dropped (rarely meaningful for an image build) and the testing checklist adjusted to what matters here: testing against a built image, and updating goss.yaml when the change affects files, ports or packages.

Summary by CodeRabbit

  • Documentation
    • Added a pull request template for Docker image contributions, including description, motivation, testing, configuration, and documentation checklists.
  • Chores
    • Assigned repository-wide code ownership for streamlined review routing.

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The repository assigns a global code owner and adds a pull request template for Docker image contributions. The template requests a description, motivation, image testing, goss.yaml updates, and documentation updates.

Changes

Repository contribution governance

Layer / File(s) Summary
Contribution governance
.github/CODEOWNERS, .github/pull_request_template.md
The repository assigns a global code owner. The pull request template adds contribution prompts and a checklist for image testing, goss.yaml, and documentation updates.

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the addition of the pull request template and CODEOWNERS file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch add-codeowners-and-pr-template

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/pull_request_template.md:
- Line 13: Update the Goss checklist item in the pull request template to
mention processes and command outputs alongside files, ports, and packages,
preserving the existing conditional wording.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: f9f6873a-305e-4880-bec3-6d6441b2c22e

📥 Commits

Reviewing files that changed from the base of the PR and between 9bb9360 and 6709a59.

📒 Files selected for processing (2)
  • .github/CODEOWNERS
  • .github/pull_request_template.md


## Checklist
- [ ] I've tested my changes against a built image
- [ ] I've updated `goss.yaml` if the change affects files, ports or packages in the image

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Include processes and command outputs in the Goss checklist.

AGENTS.md:31-34 states that Goss checks files, ports, processes, and command outputs. This checklist names only files, ports, and packages. Update the condition to include processes and command outputs.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/pull_request_template.md at line 13, Update the Goss checklist item
in the pull request template to mention processes and command outputs alongside
files, ports, and packages, preserving the existing conditional wording.

@phanan
phanan merged commit 924a038 into master Aug 10, 2026
3 checks passed
@phanan
phanan deleted the add-codeowners-and-pr-template branch August 10, 2026 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant