Skip to content

Update docker-compose.postgres.yml#223

Open
Tontonjo wants to merge 1 commit into
koel:masterfrom
Tontonjo:patch-3
Open

Update docker-compose.postgres.yml#223
Tontonjo wants to merge 1 commit into
koel:masterfrom
Tontonjo:patch-3

Conversation

@Tontonjo

@Tontonjo Tontonjo commented Jun 8, 2026

Copy link
Copy Markdown

Corrected path in container to match what Koel is expecting as mountpoint:
koel:doctor
Image storage directory public/storage/images is not readable/writable ERROR

Summary by CodeRabbit

  • Chores
    • Updated Docker image storage path configuration to ensure correct volume mounting for containerized deployments.

@coderabbitai

coderabbitai Bot commented Jun 8, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The PostgreSQL Docker Compose configuration is updated to mount the image storage volume at a new container filesystem path. The koel service's image_storage volume target is changed from /var/www/html/storage/app/public/images to /var/www/html/public/storage/images.

Changes

PostgreSQL Compose Configuration

Layer / File(s) Summary
Image storage volume mount path update
docker-compose.postgres.yml
The koel service's image_storage volume mount is updated to point to a new container path reflecting the changed image storage directory structure.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • koel/docker#221: Both PRs modify the koel service's image_storage mount target in docker-compose.postgres.yml, representing sequential updates to the image storage path as the application structure evolved.

Poem

🐰 A path through the forest of Docker does change,
From storage/app to public, how wonderfully strange!
The images now dwell in their new leafy home,
Where public/storage/images shall freely roam. 📦✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title is generic and vague. It describes the file being updated but does not convey the specific purpose or main change — fixing the image storage path to match Koel's expected mountpoint. Revise the title to be more specific and descriptive, such as 'Fix image storage mount path in docker-compose.postgres.yml' to clearly indicate the purpose of the change.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docker-compose.postgres.yml`:
- Line 17: The docker-compose service currently mounts the volume image_storage
to /var/www/html/public/storage/images which breaks the container's expected
storage contract; change the mount target for the image_storage volume to
/var/www/html/storage/app/public/images so it matches the container's
Dockerfile/README/CHANGELOG contract and ensures writes persist to the correct
path.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 80b4ca40-65d6-478d-8e5e-c281bed79f94

📥 Commits

Reviewing files that changed from the base of the PR and between 17e4c70 and 69f6168.

📒 Files selected for processing (1)
  • docker-compose.postgres.yml

volumes:
- music:/music
- image_storage:/var/www/html/storage/app/public/images
- image_storage:/var/www/html/public/storage/images

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Mount path on Line 17 breaks the container’s declared image-storage contract.

image_storage is now mounted at /var/www/html/public/storage/images, but the image builds, permissions, docs, and changelog all target /var/www/html/storage/app/public/images. This can cause writes/persistence to miss the intended volume path and reintroduce read/write failures.

Suggested fix
-      - image_storage:/var/www/html/public/storage/images
+      - image_storage:/var/www/html/storage/app/public/images

As per coding guidelines, align compose mountpoints with upstream container contracts documented in README.md:112-118, Dockerfile:82-112, and CHANGELOG.md:8-13.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- image_storage:/var/www/html/public/storage/images
- image_storage:/var/www/html/storage/app/public/images
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@docker-compose.postgres.yml` at line 17, The docker-compose service currently
mounts the volume image_storage to /var/www/html/public/storage/images which
breaks the container's expected storage contract; change the mount target for
the image_storage volume to /var/www/html/storage/app/public/images so it
matches the container's Dockerfile/README/CHANGELOG contract and ensures writes
persist to the correct path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant