🛡️ Sentinel: Fix CSV Injection in Form 2086 Export#12
🛡️ Sentinel: Fix CSV Injection in Form 2086 Export#12google-labs-jules[bot] wants to merge 1 commit into
Conversation
Implemented `escapeCSVValue` helper in `useForm2086.ts` to: 1. Escape fields containing commas, quotes, or newlines (RFC 4180). 2. Sanitize fields starting with `=, +, -, @` by prepending a single quote to prevent Formula Injection (CSV Injection) in Excel. This fixes a security vulnerability where malicious transaction data could execute arbitrary commands when the exported CSV is opened.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🛡️ Sentinel: [HIGH] Fix CSV Injection in Form 2086 Export
🚨 Severity: HIGH
💡 Vulnerability: The application was generating CSV exports by naively joining strings with commas. Malicious transaction data (e.g., currency set to
=cmd|'/C calc'!A0) could execute code when the user opens the exported Form 2086 in Excel (CSV/Formula Injection). It also broke the CSV structure if data contained commas.🎯 Impact: Potential Arbitrary Code Execution (ACE) on the client's machine if they download and open the tax report.
🔧 Fix: Implemented strict CSV escaping and formula sanitization in
app/composables/useForm2086.ts.✅ Verification: Verified logic with
tests/csv_security_check.js(created temporarily) ensuring all malicious patterns are escaped and quoted correctly.PR created automatically by Jules for task 11456937981608122179 started by @kodelio