🛡️ Sentinel: [MEDIUM] Fix insecure CSV parsing#11
🛡️ Sentinel: [MEDIUM] Fix insecure CSV parsing#11google-labs-jules[bot] wants to merge 1 commit into
Conversation
…oted fields
The previous implementation used `split(',')` which incorrectly split fields containing commas.
This change introduces `parseCSVLine`, a state-machine based parser that respects quoted fields and escaped quotes.
It also handles CRLF line endings.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
split(',')which failed on fields containing commas (e.g. descriptions), leading to data corruption or potential injection.parseCSVLinehelper that respects double quotes and handles escaped quotes, following standard CSV rules.repro_csv.js) that the new parser handles quoted fields with commas correctly.PR created automatically by Jules for task 11399944277198355893 started by @kodelio