fix: pandas 3 and scikit-learn 1.9 compatibility, and improve dependency testing - #816
Merged
Conversation
FBruzzesi
commented
Aug 1, 2026
Comment on lines
+24
to
+26
| "numpy>=1.26.4", | ||
| "pandas>=2.0.3", | ||
| "scikit-learn>=1.4.2", |
Collaborator
Author
There was a problem hiding this comment.
- Adding numpy to avoid it via transitive dependency, and pinning a min version
- pandas 2.0.3 was released 3+ years ago (2023-06-28)
- scikit 1.4.2 was released ~2.5 years ago (2024-04-09)
FBruzzesi
commented
Aug 1, 2026
Comment on lines
+49
to
+51
| cvxpy = ["cvxpy>=1.5.2"] | ||
| formulaic = ["formulaic>=0.6.0"] | ||
| umap = ["umap-learn>=0.4.6", "numpy<2.0"] | ||
| umap = ["umap-learn>=0.5.8", "numba>=0.61"] |
Collaborator
Author
There was a problem hiding this comment.
- cvxpy 1.5.2 was released 2+ years ago (2024-06-18)
- umap-learn 0.5.8 was released 1+ years ago (2025-06-30) - This is the most recent release in the bump. It allows us to pin numpy < 2.0
Collaborator
Author
|
@koaning if we decide to go ahead with this one, I think it might be worth a minor version bump as it has quite some dependency version bumps AND one breaking change. |
FBruzzesi
marked this pull request as ready for review
August 1, 2026 21:05
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pandas 3 made
Daya calendar offset, soTimeGapSplit.summary()'sfrequencycolumn silently became24hinstead ofD; it now emits the pandas 3 rendering on every supported pandas version.scikit-learn 1.9 additionally runs
check_array_api_inputon estimators taggedarray_api_support=False, so 11 such checks are declared expected failures with reasons.CI could not have caught either:
uv runre-synced the test job back touv.lock, discarding theuv pip installit was meant to be testing, and the nightly "latest" job was pinned to Python 3.10, where pandas 3 and scikit-learn 1.9 do not install at all.Both fixed, plus dependency floors that could never install (
pandas>=1.1.5fails to build,scikit-learn>=1.0contradictssklearn-compat) and the two-year-oldnumpy<2.0cap. Dropping it neededcvxpy>=1.5.2,umap-learn>=0.5.8and a numba floor, and lets the PR job finally reach pandas 3.A new
minimum-versionsjob verifies every bound with--resolution lowest-direct.Breaking:
summary()["frequency"]returns24hwhere it previously returnedDto align with pandas v3+ behavior.