chore(monitor): retire three acknowledgements production has satisfied - #7120
Merged
Conversation
The seed-freshness monitor named these on every run: - recovered: flightDelays:STALE_SEED no longer reported; remove it (#6987). - recovered: tpsMci:EMPTY no longer reported; remove it (#7035). - recovered: tpsCallsAttended:EMPTY no longer reported; remove it (#7036). All three expired days ago — flightDelays on 2026-08-21, the two TPS probes on 2026-08-22 — and all three now report a status the acknowledgement does not name, so none of them was suppressing anything. The pass line already read `0 acknowledged` with them still in the file. They are removed rather than re-dated. Each covered a cutover that has since completed: flightDelays the probe moved onto seed-meta:aviation:delays-bootstrap and the aggregate now publishes its own meta (#6987), so the STALE_SEED window it covered is closed. tpsMci both now publish; EMPTY is no longer what they report. tpsCallsAttended An expired acknowledgement is worse than none: it is noise on every run, and the next real problem on one of these probes would arrive next to three lines telling an operator to ignore something. Clearing them also removes the baseline-wide 2026-08-27 expiry as a live deadline — `expired` is only evaluated when `acknowledged` is non-empty, so an empty list cannot trip it. Deliberately NOT included: the `cutover: { mode: 'expiring-ack', ... }` declarations these three carry in api/health.js. That looks like a matching pair to remove, and it is not — api/health.js holds ~13 such declarations against a baseline that held 3, so a declaration outliving its acknowledgement is this repo's steady state rather than a leftover. check-health-probe-cutovers.mts only consults them when a probe key actually changes, which is why the gate passes here. Removing them would be a separate change needing its own per-probe argument. Verified: monitor exits 0 with no recovered lines (`no unacknowledged health problems (0 acknowledged)`); the health-probe cutover gate passes; 190 tests pass across seed-freshness-monitor, seed-freshness-workflow, health-classify and the relay boot guard. Biome clean. Claude-Session: https://claude.ai/code/session_01QBV6rYWJd62owNKBrkgZxa
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The seed-freshness monitor named these on every run:
All three expired days ago —
flightDelayson 2026-08-21, the two TPS probes on 2026-08-22 — and each now reports a status its acknowledgement does not name. None was suppressing anything: the pass line already read0 acknowledgedwith them still in the file.Removed rather than re-dated
Each covered a cutover that has since completed:
flightDelaysseed-meta:aviation:delays-bootstrapand the aggregate publishes its own meta (#6987), closing theSTALE_SEEDwindowtpsMciEMPTYis not what it reportstpsCallsAttendedAn expired acknowledgement is worse than none. It is noise on every run, and the next real problem on one of these probes would arrive next to three lines telling an operator to ignore something.
Clearing them also retires the baseline-wide 2026-08-27 expiry as a live deadline:
expiredis only evaluated whenacknowledgedis non-empty, so an empty list cannot trip it.Deliberately not included
The
cutover: { mode: 'expiring-ack', … }declarations these three carry inapi/health.js.That looks like the matching half to remove, and it is not.
api/health.jsholds ~13 such declarations against a baseline that held 3 — so a declaration outliving its acknowledgement is this repo's steady state, not a leftover.check-health-probe-cutovers.mtsonly consults them when a probe key actually changes, which is why the gate passes here.Removing them would be a separate change needing its own per-probe argument, and removing only these three would make the file less consistent, not more.
Verification
No recovered lines remain. Health-probe cutover gate passes. 190 tests pass, 0 fail across seed-freshness-monitor, seed-freshness-workflow, health-classify and the relay boot guard. Biome clean.
Production health at time of writing: HEALTHY, 280/284 OK, with the four remaining all by design — two on-demand probes,
crossStraitActivityJapanMod(explicitSOURCE_BLOCKEDcarve-out) anddisplacementPrev(OK_CASCADE).