[codex] Add module-info.java via multi-release JAR - #145
Open
cowwoc wants to merge 1 commit into
Open
Conversation
cowwoc
marked this pull request as ready for review
June 5, 2026 17:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Adds a JPMS
module-info.javaforcom.knuddels.jtokkitwhile preserving Java 8 compatibility by publishing the library JAR as a multi-release JAR.Why
The library targets Java 8, so a plain top-level module descriptor would break that baseline. Packaging
module-info.classunderMETA-INF/versions/9/keeps Java 8 consumers unchanged while exposing a named module on Java 9+.Impact
com.knuddels.jtokkitas a named module.module-info.java.Validation
JAVA_HOME=/opt/sdkman/candidates/java/21.0.8-zulu PATH=/opt/sdkman/candidates/java/21.0.8-zulu/bin:$PATH java -classpath gradle/wrapper/gradle-wrapper.jar org.gradle.wrapper.GradleWrapperMain :lib:check :lib:jarMETA-INF/versions/9/module-info.classMulti-Release: true