Add more (isobaric) diags to isolevels-v8#2
Open
zmoon wants to merge 11 commits into
Open
Conversation
not geopotential it comes from the zgrid model variable (layer interface heights), like the height_<lev>hPa variables
so ertel_pv is up-to-date when we compute ertel_pv_isobaric
instead of dtheta_dt_mp, for the PV budget diagnostics computation decision dtheta_dt_mp is computed in src/core_atmosphere/physics/mpas_atmphys_interface.F so maybe this was a typo
was hPa, needs to be Pa
There was a problem hiding this comment.
Pull request overview
This PR extends the core atmosphere isobaric diagnostics set (isolevels-v8) by adding additional tendency and PV fields on isobaric surfaces, and ensures prerequisite diagnostics are computed by adjusting dependency checks and call ordering.
Changes:
- Add new isobaric registry fields for explicit mixing heating, multiple physics/dynamics theta tendencies, and Ertel PV on isobaric levels.
- Update PV diagnostics dependency logic so
ertel_pv/dtheta_dt_mixare computed when their isobaric counterparts are requested. - Reorder diagnostics manager calls so PV diagnostics run before isobaric interpolation.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/core_atmosphere/diagnostics/Registry_isobaric.xml |
Registers additional isobaric output variables (tendencies, PV) and clarifies z-isobaric description. |
src/core_atmosphere/diagnostics/mpas_pv_diagnostics.F |
Expands “need” logic to compute PV/mixing prerequisites when isobaric outputs are requested. |
src/core_atmosphere/diagnostics/mpas_isobaric_diagnostics.F |
Interpolates additional fields to isobaric levels; adds new need_* flags and pool access for new diagnostics. |
src/core_atmosphere/diagnostics/mpas_atm_diagnostics_manager.F |
Reorders setup/compute sequence so PV diagnostics precede isobaric diagnostics. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1259
to
+1270
| if (need_rthcuten_isobaric) then | ||
| do iCell = 1, nCells | ||
| do k = 1, nVertLevels | ||
| kk = nVertLevels + 1 - k | ||
| field_in(iCell,kk) = rthcuten(k,iCell) | ||
| end do | ||
| end do | ||
| call interp_tofixed_pressure(nCells, nVertLevels, nIsoLevelsT, press_in, field_in, press_interp, field_interp) | ||
| do k = 1, nIsoLevelsT | ||
| rthcuten_isobaric(k,1:nCells) = field_interp(1:nCells,k) | ||
| end do | ||
| end if |
Comment on lines
+1285
to
+1296
| if (need_rthmpten_isobaric) then | ||
| do iCell = 1, nCells | ||
| do k = 1, nVertLevels | ||
| kk = nVertLevels + 1 - k | ||
| field_in(iCell,kk) = rthmpten(k,iCell) | ||
| end do | ||
| end do | ||
| call interp_tofixed_pressure(nCells, nVertLevels, nIsoLevelsT, press_in, field_in, press_interp, field_interp) | ||
| do k = 1, nIsoLevelsT | ||
| rthmpten_isobaric(k,1:nCells) = field_interp(1:nCells,k) | ||
| end do | ||
| end if |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.