Repository navigation
Okon tcm client - #10
Draft
mpfmorawski wants to merge 6 commits into
Draft
mpfmorawski wants to merge 6 commits into
mpfmorawski wants to merge 6 commits into
Conversation
Contributor
|
Repo re-org should be in a separate PR. I would move all js-related code to |
Contributor
|
I would think about excluding this whole serial communication from jetson repository and then using it as a submodule both in jetson and autonomy repository. Now that you have copied the serial code from jetson repository, it's gonna to be hard to keep up with updates to serial (you would have to manually update them). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous discussions can be found in #8 issue.
What have been done
I have improved jetson_serial_light module implemented by @RoboAsystent . I changed used
Lock()fromthreading.Lock()tomultiprocessing.Lock()and added debug modes for checking communication.What I want to be done
Log files
In the jetson_serial_light module file, I prepared flags (
BUFFER_DEBUG_MODE, etc.) for debugging, so that you can observe what is happening directly with the communication. I would like to ask you (@niemiaszek and @RoboAsystent) to analyze the log files I prepared by running thejetson_serial_light.pyscript and approve (or not 😉) that at this point the communication is working properlyBUFFER_DEBUG_MODE = True,DATA_DEBUG_MODE = True,LOCK_DEBUG_MODE = True,SLEEP_BETWEEN_WRITE_AND_READ = FalseBUFFER_DEBUG_MODE = True,DATA_DEBUG_MODE = True,LOCK_DEBUG_MODE = True,SLEEP_BETWEEN_WRITE_AND_READ = TrueFiles structure
I feel that currently the file structure in this repository is in a complete mess. I would greatly appreciate @niemiaszek if you could suggest how exactly to build the file structure.
Improving code
Of course, as always, I will be very grateful for all comments on how to make the code better.
Important informations from me
Pull Request for now please be a draft. I wish we had a place to directly discuss the code because of the group work on this task.
In addition, I am leaving (August 18 - August 21) and unfortunately will not be available during this time.