Skip to content

Okon tcm client - #10

Draft
mpfmorawski wants to merge 6 commits into
masterfrom
okon-tcm-client
Draft

mpfmorawski wants to merge 6 commits into
masterfrom
okon-tcm-client

Conversation

@mpfmorawski

Copy link
Copy Markdown
Collaborator

Previous discussions can be found in #8 issue.

What have been done

I have improved jetson_serial_light module implemented by @RoboAsystent . I changed used Lock() from threading.Lock() to multiprocessing.Lock() and added debug modes for checking communication.

What I want to be done

Log files

In the jetson_serial_light module file, I prepared flags (BUFFER_DEBUG_MODE, etc.) for debugging, so that you can observe what is happening directly with the communication. I would like to ask you (@niemiaszek and @RoboAsystent) to analyze the log files I prepared by running the jetson_serial_light.py script and approve (or not 😉) that at this point the communication is working properly

  • log_without_sleep.txt - log file with flags set to BUFFER_DEBUG_MODE = True, DATA_DEBUG_MODE = True, LOCK_DEBUG_MODE = True, SLEEP_BETWEEN_WRITE_AND_READ = False
  • log_with_sleep.txt - log file with flags set to BUFFER_DEBUG_MODE = True, DATA_DEBUG_MODE = True, LOCK_DEBUG_MODE = True, SLEEP_BETWEEN_WRITE_AND_READ = True

Files structure

I feel that currently the file structure in this repository is in a complete mess. I would greatly appreciate @niemiaszek if you could suggest how exactly to build the file structure.

Improving code

Of course, as always, I will be very grateful for all comments on how to make the code better.

Important informations from me

Pull Request for now please be a draft. I wish we had a place to directly discuss the code because of the group work on this task.
In addition, I am leaving (August 18 - August 21) and unfortunately will not be available during this time.

@mpfmorawski mpfmorawski self-assigned this Aug 17, 2022
@niemiaszek

Copy link
Copy Markdown
Contributor

Repo re-org should be in a separate PR. I would move all js-related code to /js, as it is deprecated (we only plan to use python for now). All tasks should be moved to /tasks folder. Code for menaging connection like okon_client.py etc. should be moved to /okon. Utils like go_to_starting_line.py go to /utils. Finally, examples should go to /examples.

@niemiaszek

Copy link
Copy Markdown
Contributor

I would think about excluding this whole serial communication from jetson repository and then using it as a submodule both in jetson and autonomy repository. Now that you have copied the serial code from jetson repository, it's gonna to be hard to keep up with updates to serial (you would have to manually update them).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants