deps: updates vtprotobuf to 0.6.0#83
Open
ArthurHDRodrigues wants to merge 1 commit into
Open
Conversation
knqyf263
reviewed
Jul 12, 2026
| } | ||
|
|
||
| b, err := g.Content() | ||
| cfg := &vtgenerator.Config{} |
Owner
There was a problem hiding this comment.
It looks like this breaks code generation for the custom well-known types in this repository. After regenerating the files with make -B protoc, types/known/structpb/struct_vtproto.pb.go contains an empty import path, and make test fails with invalid import path.
Could you check the WKT handling in the v0.6 migration and add a regression test?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
For context, I'm packaging Docker in GNU Guix, which depends on fsutil, which depends on vtprotobuf v0.6.0 (v0.4.0 doesn´t work :/). Just updating vtprotobuf breaks your package, so I'm trying to update it so everything uses 0.6.0.
Any feedback is welcome :)
Issue #, if available: No issue.
Description of changes:
Minimal changes so that the project uses vtprotobuf v0.6.0 instead of v0.4.0.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.