fix: decode BC OData enum encoding so G/L Account lines show in cost breakdowns

[EdiWeeks]

Summary

Job Planning Lines of Type = G/L Account were not appearing in the Budget Cost and Billable Price per-type breakdowns on the project details page — the G/L Account row always showed £0.

Root cause: BC's OData serializer URL-encodes named enum values, so type "G/L Account" arrives over the wire as G_x002F_L_x0020_Account (/ → _x002F_, space → _x0020_). Thyme compared the raw value against the plain 'G/L Account' string, so these lines never matched. (The same encoding was already handled for lineType but not for type.)

Confirmed against live production BC — /jobPlanningLines for PR00100 task 9999 returns:

{ "lineType": "Budget",   "type": "G_x002F_L_x0020_Account", "totalCost": 500 }
{ "lineType": "Billable", "type": "G_x002F_L_x0020_Account", "totalPrice": 24000 }

Changes

• src/utils/unitConversion.ts — add decodeBCEnum(), which generically decodes BC's _xHHHH_ enum escapes (not hardcoded to one value — decodes whatever BC sends).
• src/services/bc/bcClient.ts — decode type and lineType once at the fetch boundary (getJobPlanningLines and getJobPlanningLinesForWeek), so all downstream comparisons use the plain values.
• tests/unit/utils/unitConversion.test.ts — 4 new tests covering the exact wire value confirmed from production.

Test plan

• Confirmed root cause against live production BC (/jobPlanningLines, PR00100 task 9999)
• bun run test — 37/37 unit tests pass (incl. new decodeBCEnum cases)
• bun run typecheck — clean
• bun run lint — 0 errors
• bun run build — succeeds
• Manually verified on project PR00100: Budget Cost G/L Account row now shows £500.00 and Billable Price G/L Account row shows £24,000.00 (previously £0.00)

Note: bun run format:check flags ~161 files locally due to a Windows CRLF/line-ending mismatch (pristine main files I never touched also fail). The committed blobs are LF (core.autocrlf=true), so CI's format check passes.

Fixes #211

🤖 Generated with Claude Code

[Copilot]

Pull request overview

This PR fixes missing G/L Account Job Planning Lines in the project details cost breakdowns by decoding Business Central’s OData enum escaping (e.g. G_x002F_L_x0020_Account → G/L Account) so downstream comparisons operate on plain values.

Changes:

• Added a generic decodeBCEnum() helper to decode BC _xHHHH_ enum escapes.
• Normalized type and lineType in bcClient when fetching job planning lines (decode at the boundary).
• Added unit tests covering the production-confirmed encoded enum values.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
src/utils/unitConversion.ts	Introduces decodeBCEnum() used to normalize BC enum strings.
src/services/bc/bcClient.ts	Decodes planning-line type/lineType during fetch to fix downstream matching.
tests/unit/utils/unitConversion.test.ts	Adds unit tests validating enum decoding behavior (including production example).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.