docs(rfc): RFC 0003 — SUAVE dependency isolation - #40
Closed
aligatoralex wants to merge 1 commit into
Closed
aligatoralex wants to merge 1 commit into
aligatoralex wants to merge 1 commit into
Conversation
Preliminary design proposal (RFC) for how YAADO should depend on SUAVE 2.5.2, based on the hands-on install findings in PR #33: it needs --no-build-isolation plus three runtime shims and must stay out of the uv-locked env. Proposes a dedicated venv + a maintained suave_compat shim module (turning the exploration monkeypatches into tested code) now, a baked container later, and a separate CI job for the #29 gated test. Rejects vendoring patches into the pinned submodule. For team review. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NPJaUV26PzaRdYKr3Q7z1d
This was referenced Aug 31, 2026
Contributor
Author
|
Superseded by #47 — this RFC's content moves unchanged to Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes:
Adds
docs/rfc/0003-suave-dependency-isolation.md— an RFC on how YAADO should depend on SUAVE, based on the hands-on install in PR #33. No code changes.Key points for review:
--no-build-isolation+ three runtime shims and must stay out of theuv-locked env.suave_compatshim module (recommended now), baked container/devcontainer (later), vendoring patches into the submodule (rejected — pinned submodule).VehicleFactoryto support vehicle-agnostic ComponentStore architecture #29 SUAVE-gated test needs its own job (submodule checkout + shimmed venv), and stayingSKIPPEDin the shared env is the correct default until then.scipy.misc.derivativeshim is not yet numerically validated.Checklist:
uv run pytest YAADO_Core/tests/and all tests pass. (Docs-only.)docs/rfc/.)Verification method:
Every technical claim traces to the reproduced commands/errors in PR #33 (
docs/SUAVE_INTEGRATION_NOTES.md).Generated by Claude Code