docs(rfc): RFC 0001 — solid-motor modeling options - #36
Closed
aligatoralex wants to merge 1 commit into
Closed
aligatoralex wants to merge 1 commit into
aligatoralex wants to merge 1 commit into
Conversation
Preliminary design proposal (RFC) for how YAADO should model solid-fuel motors. Records that the SolidMotor schema and the 3-DOF boost solver already model solids natively today, and that the only gap is the SUAVE bridge (SUAVE 2.5.2 has no solid network, per PR #33). Lays out four options (native solver, map to Liquid_Rocket, fork SUAVE, hybrid staging) with trade-offs and recommends native + hybrid. For team review. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NPJaUV26PzaRdYKr3Q7z1d
This was referenced Aug 31, 2026
Contributor
Author
|
Superseded by #47 — this RFC's content moves unchanged to Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes:
Adds
docs/rfc/0001-solid-motor-modeling.md— a Request-for-Comments design proposal for modeling solid-fuel motors in YAADO. No code changes.Key points for review:
SolidMotorschema is complete and thePointMass3DOFBoostAnalysisboost solver consumes it — the only gap is the SUAVE bridge (SUAVE 2.5.2 has no solid network, confirmed in PR docs: SUAVE 2.5.2 install/integration notes (feasibility + API validation) #33, so [FEATURE] UpdateVehicleFactoryto support vehicle-agnostic ComponentStore architecture #29 raisesNotImplementedError).SolidMotorPerformanceAnalysis, B map to SUAVELiquid_Rocket, C fork SUAVE, D hybrid staging.NotImplementedErroras an honest boundary.Checklist:
uv run pytest YAADO_Core/tests/and all tests pass. (Docs-only; suite unaffected.)docs/rfc/.)Verification method:
Statements about current capability were cross-checked against
ComponentStore/propulsion.py::SolidMotorandflight_dynamics/methods/point_mass_3dof.py; the SUAVE-network claim is backed by the real-install probe in PR #33.Generated by Claude Code