⚡ Bolt: Optimize dynamic SQL generation in D1 targets

[bashandbone]

💡 What:
Replaced intermediate Vec allocations and format! operations in build_upsert_stmt and build_delete_stmt with pre-allocated String::with_capacity and write! macro calls.

🎯 Why:
The previous implementation involved allocating temporary vectors for columns, placeholders, and clauses, and then repeatedly doing join(", ") string allocations inside tight execution paths. Using write! directly to a pre-allocated string minimizes heap churn and memory copies during the performance-sensitive dynamic SQL generation routines for the Cloudflare D1 integration.

📊 Impact:
Reduces execution time for build_upsert_stmt by ~62.8%, build_delete_stmt by ~53.4%, and batches of 10 upserts by ~67.5% according to localized benchmark runs. Eliminates several O(n) heap allocations per statement build.

🔬 Measurement:
Run the targeted benchmark: cargo bench -p thread-flow --bench d1_profiling statement_generation and verify the metrics.

---

PR created automatically by Jules for task 5440273456239079234 started by @bashandbone

Summary by Sourcery

Optimize dynamic SQL statement construction for Cloudflare D1 targets to reduce allocations and improve performance.

Enhancements:

• Refine D1 upsert SQL generation to build statements directly into pre-allocated strings while collecting parameters in a single pass.
• Refine D1 delete SQL generation to construct WHERE clauses directly into a pre-allocated SQL buffer without intermediate collections.

Documentation:

• Add a Bolt engineering note documenting best practices for efficient dynamic SQL generation using pre-allocated strings and write! macros.

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[sourcery-ai]

Reviewer's Guide

Optimizes dynamic SQL generation for Cloudflare D1 upsert/delete statements by replacing intermediate Vec and format!/join-based construction with pre-sized String buffers and write!-based streaming assembly, and documents the pattern in the Bolt performance guide.

File-Level Changes

Change	Details	Files
Refactored D1 upsert SQL generation to build the statement directly into a pre-sized String using write! and a single params Vec, eliminating intermediate collections and format! calls.	Introduce std::fmt::Write usage and pre-compute the params Vec capacity from key and value schema lengths. Estimate SQL length for INSERT ... ON CONFLICT statement and allocate a String with String::with_capacity to avoid reallocations. Stream column list construction for key and value fields directly into the SQL String while simultaneously pushing JSON-converted params. Generate the VALUES placeholder list based on params length using write! instead of building a Vec of placeholder strings and joining. Stream ON CONFLICT DO UPDATE SET clauses directly into the SQL String by iterating value_fields_schema and writing field = excluded.field pairs with comma separation.	crates/flow/src/targets/d1.rs
Refactored D1 delete SQL generation to use a pre-sized String and write!-based clause construction instead of Vec plus format!/join.	Introduce std::fmt::Write and pre-allocate params Vec based on key_fields_schema length. Estimate DELETE statement length and allocate String::with_capacity for the SQL buffer. Stream the WHERE clause conditions (field = ?) into the SQL buffer with proper AND separators while filling params from key parts. Remove intermediate where_clauses Vec and final format!/join-based SQL assembly.	crates/flow/src/targets/d1.rs
Documented the dynamic SQL generation optimization pattern in the Bolt performance guide for future reference.	Add a dated note describing the performance impact of replacing Vec + format!/join with String::with_capacity + write! for D1 SQL generation. Record the recommended action to prefer streaming writes into pre-allocated Strings for dynamic query construction to minimize heap allocations and string copies.	.jules/bolt.md

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• All of the write! calls ignore their Result via let _ = ...; consider either propagating errors (e.g. via ?) or wrapping them in a small helper that asserts success to avoid silently swallowing unexpected fmt::Errors and to keep clippy happy.
• The hard-coded constants in the estimated_len calculations (e.g. 12, 28, * 15) make the sizing logic brittle and hard to maintain; consider extracting them into named constants or comments tied directly to the SQL fragments so future changes to the query shape don’t desync the estimates.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- All of the `write!` calls ignore their `Result` via `let _ = ...`; consider either propagating errors (e.g. via `?`) or wrapping them in a small helper that asserts success to avoid silently swallowing unexpected `fmt::Error`s and to keep clippy happy.
- The hard-coded constants in the `estimated_len` calculations (e.g. `12`, `28`, `* 15`) make the sizing logic brittle and hard to maintain; consider extracting them into named constants or comments tied directly to the SQL fragments so future changes to the query shape don’t desync the estimates.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}