🛡️ Sentinel: [CRITICAL] Fix path normalization vulnerability in typescript extractor

[bashandbone]

🚨 Severity: CRITICAL
💡 Vulnerability: The std::path::Component loop in the typescript extractor's path normalization carelessly popped elements without checking stack bounds or root prefixes. When .. ParentDir components were encountered without a previous valid element on the stack (i.e. standard relative path syntax like ../../file.ts), it effectively ignored the .. elements, altering the path destination or enabling directory traversal escape vulnerabilities. It also falsely popped root/prefix elements.
🎯 Impact: This caused faulty module resolution and enabled path traversal outside of bounded analysis directories, presenting a serious security traversal risk.
🔧 Fix: Explicitly prevented popping bounded constants (RootDir/Prefix). Updated logic to push the ParentDir instead of ignoring it when the stack is empty or its preceding element is also a ParentDir (to natively preserve consecutive ../../).
✅ Verification: Ran cargo +nightly fmt, cargo clippy, the workspace tests to verify no regressions existed (cargo test --workspace -- --skip incremental_postgres_tests --skip incremental_integration_tests), and targeted tests (cargo test -p thread-flow --test extractor_typescript_tests) indicating normal functional parity was maintained securely. Also formatted and included learnings in .jules/sentinel.md.

---

PR created automatically by Jules for task 9407032769846878330 started by @bashandbone

Summary by Sourcery

Fix insecure path normalization in the TypeScript dependency extractor and apply minor cleanups and documentation updates.

Bug Fixes:

• Harden TypeScript extractor path normalization to correctly handle parent directory components without escaping root or altering intended relative paths.

Enhancements:

• Simplify function signatures and locking logic in the rule engine and tree-sitter integration for improved clarity and consistency.

Documentation:

• Add sentinel documentation describing the path normalization vulnerability, its root cause, and prevention guidelines.

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[sourcery-ai]

Reviewer's Guide

Fixes a critical path normalization vulnerability in the TypeScript incremental extractor by correctly handling ParentDir components in a component stack, adds a security learnings doc entry, and includes minor formatting and lifetime-cleanup refactors elsewhere in the codebase.

File-Level Changes

Change	Details	Files
Harden path normalization for TypeScript dependency extraction to prevent directory traversal and incorrect module resolution.	Replace unconditional stack pop on ParentDir with logic that prevents popping RootDir/Prefix components. When the component stack is empty or the last element is also ParentDir, push the ParentDir instead of ignoring it to preserve relative path semantics like ../../file.ts. Otherwise continue to pop the last non-parent component for ParentDir, and keep behavior for CurDir and other components unchanged.	crates/flow/src/incremental/extractors/typescript.rs
Apply small ergonomic and formatting cleanups in AST and rule engine modules.	Reformat UTF-8 fallbacks and parser test assertions for readability while keeping behavior identical. Simplify function signatures in check_var by removing unused lifetimes and taking references directly. Condense Registration::read error handling into a single chained expression and reformat Rule::defined_vars for clarity.	crates/ast-engine/src/tree_sitter/mod.rs crates/rule-engine/src/check_var.rs crates/rule-engine/src/rule/mod.rs crates/rule-engine/src/rule/referent_rule.rs
Document the vulnerability and its mitigation in the Sentinel learnings log.	Add a Sentinel entry describing the original path traversal issue, the pitfalls of naive ParentDir handling, and recommended safe patterns for manual path normalization.	.jules/sentinel.md

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}