🛡️ Sentinel: [HIGH] Fix path traversal in manual path normalization

[bashandbone]

🚨 Severity

HIGH

💡 Vulnerability

A path traversal vulnerability existed in crates/flow/src/incremental/extractors/typescript.rs during manual module path resolution fallback. When iterating through std::path::Component entries and encountering Component::ParentDir (../), the code unconditionally popped the last component from the constructed path's component list. This allowed ../ components to pop root directories (Component::RootDir), prefixes (Component::Prefix), or erroneously ignored leading ../ sequences by popping from an empty stack, leading to unauthorized path traversal and incorrectly constructed relative paths.

🎯 Impact

The application could have resolved paths outside of intended base directories or constructed corrupted internal module graphs, potentially leading to unauthorized file access during graph building and parsing phases.

🔧 Fix

Updated Component::ParentDir handling to explicitly check the top of the stack. It now blocks ParentDir from popping RootDir or Prefix. Additionally, it correctly preserves leading ../ sequences by explicitly pushing ParentDir when the component list is empty or the last element is also a ParentDir.

✅ Verification

1. Run formatting: cargo +nightly fmt
2. Run linting: cargo clippy --workspace -- -D warnings
3. Run tests to ensure extraction works correctly: cargo test -p thread-flow --test extractor_typescript_tests
4. Confirm no untracked .orig or .rej patch files remain.

---

PR created automatically by Jules for task 14907076982299675260 started by @bashandbone

Summary by Sourcery

Fix unsafe manual path normalization in the TypeScript dependency extractor to prevent path traversal and document the incident in Sentinel metadata.

Bug Fixes:

• Prevent ../ components from popping root or prefix segments during manual path normalization in the TypeScript extractor.
• Preserve leading parent directory components when normalizing paths to maintain correct relative navigation semantics.

Documentation:

• Add Sentinel security incident note documenting the path traversal vulnerability, root cause, and remediation guidance.

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Fixes a path traversal vulnerability in the TypeScript dependency extractor’s manual path normalization and adds a Sentinel security note documenting the issue and its prevention.

File-Level Changes

Change	Details	Files
Harden manual path normalization to prevent improper handling of .. path components and path traversal outside allowed roots.	Replace unconditional pop on encountering Component::ParentDir with logic that inspects the last accumulated component. Allow ParentDir to remove only normal path components, never root or prefix components. Preserve leading and consecutive ParentDir components by pushing them when the component stack is empty or the last component is also ParentDir. Keep behavior for CurDir and other components unchanged aside from integrating with the new branching.	crates/flow/src/incremental/extractors/typescript.rs
Document the vulnerability, its root cause, and prevention guidance in a Sentinel security record.	Add a new .jules/sentinel.md file describing the path traversal issue in the TypeScript extractor. Summarize the learning about safe Component::ParentDir handling and constraints around root/prefix components. Provide prevention guidance for future manual path normalization logic.	.jules/sentinel.md

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• The new ParentDir handling duplicates the Component variants as fully-qualified paths; consider importing std::path::Component at the top of the file so the match arms and stack logic read more clearly.
• It might be helpful to encode the intent of the new ParentDir rules in a small helper function (e.g., normalize_parent_dir_component(components, component)) to keep the main loop focused on flow and reduce the chance of subtle regressions if this logic needs to be updated again.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The new `ParentDir` handling duplicates the `Component` variants as fully-qualified paths; consider importing `std::path::Component` at the top of the file so the match arms and stack logic read more clearly.
- It might be helpful to encode the intent of the new `ParentDir` rules in a small helper function (e.g., `normalize_parent_dir_component(components, component)`) to keep the main loop focused on flow and reduce the chance of subtle regressions if this logic needs to be updated again.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}