fix(figurecomposer): show controls for selected BZ mode - #553
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #553 +/- ##
==========================================
- Coverage 91.94% 91.93% -0.01%
==========================================
Files 250 250
Lines 98809 98821 +12
Branches 16610 16610
==========================================
+ Hits 90845 90854 +9
- Misses 4576 4577 +1
- Partials 3388 3390 +2 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kzcontrols only for in-plane Brillouin-zone slices.Root cause
The Brillouin-zone editor added both momentum rows without connecting their
visibility to the selected slice mode.
Validation
QT_QPA_PLATFORM=offscreen QT_API=pyqt6 uv run pytest -q tests/interactive/imagetool/manager/figurecomposer/test_overlays.py(26 passed)QT_QPA_PLATFORM=offscreen QT_API=pyside6 uv run pytest -q tests/interactive/imagetool/manager/figurecomposer/test_overlays.py(26 passed)uv run ruff check src/erlab/interactive/_figurecomposer/_operations/_bz_overlay.py tests/interactive/imagetool/manager/figurecomposer/test_overlays.pyuv run ruff format --check src/erlab/interactive/_figurecomposer/_operations/_bz_overlay.py tests/interactive/imagetool/manager/figurecomposer/test_overlays.pyuv run mypy src/erlab/interactive/_figurecomposer/_operations/_bz_overlay.pygit diff --check