fix(interactive): infer KTool guideline delta sign - #551
Merged
Conversation
Infer the delta sign from the axes configuration and the displayed alpha-beta axis order. Resolve missing configurations after user selection without changing explicit delta inputs.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #551 +/- ##
=======================================
Coverage 91.92% 91.93%
=======================================
Files 250 250
Lines 98764 98776 +12
Branches 16604 16608 +4
=======================================
+ Hits 90793 90805 +12
- Misses 4580 4581 +1
+ Partials 3391 3390 -1 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
alphaandbeta, in either order.initial_deltavalues.Root cause
ImageTool guideline angles follow display-axis direction. KTool delta follows an axes-configuration convention. The previous handoff always negated the guideline angle before a missing configuration was resolved. Type 2 configurations and reversed alpha-beta display order could therefore produce the wrong sign.
Validation
uv run pytest tests/interactive/test_kspace.py- 137 passed with PyQt6.uv run pytest tests/interactive/imagetool/test_imagetool.py -k 'open_in_ktool'- 7 passed with PyQt6.uv run mypy srcuv run ruff checkuv run ruff format --checkgit diff --check