Repository navigation
Complete pinned cyber serial provider and captured lock contracts - #158
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5dfc0d2954
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| if serial_profile: | ||
| use_native_tools = ( | ||
| provider_profile.capabilities.supports_tools | ||
| and provider_tools_cfg.get("use_native") is not False | ||
| ) |
There was a problem hiding this comment.
When a serial profile is used with native tools and the caller omits turn_strategy, the default flow is assistant_continuation. That path records the tool output as a new assistant message instead of appending a Chat Completions tool-role message for the preceding tool call, so the second serial request has an invalid native-tool history and compatible providers will reject it. The profile documentation says both flow and relay must be tool_role, but this new serial path neither validates nor supplies those settings; enforce them or fail before issuing the first request.
Useful? React with 👍 / 👎.
e393b59
into
e4src/trusted-argv-nonlogin-v11
1 participant
Compat reviewed: non-breaking. Independent read-only review covered preserved default streaming/native compaction/socket cancellation/sampling identity and exact serial caller repairs. Campaign-only backport onto authenticated native baseline44754, not a main API cutover. Ports existing private serial provider feature, completes facade/provenance callers, persists exact multipart serial prefixes, and derives locks from actual captured numeric bytes. Actual conductor TypeError and wire-prefix red-before reproduced; real two-turn HTTP/read-tool proof passes after. Provider/compiler suite286 passed; final installed private contracts650 passed with one macOS Linux skip/six warnings and disclosed negative journal fixture exception. Actual installed temperature1.0 compiler locked derivation and six serial HTTP paths passed. Four-image installed composition/native/profile/kernel proof343 pending; no grading, training, qualification, or external acceptance claim. No review requested.