Add targeted tests to close coverage gaps in cli.py, core.py, metrics.py#104
Merged
Conversation
Raises overall coverage from 93% to 99% (cli.py, metrics.py, config.py, path_resolver.py, and utils.py now at 100%; core.py at 98%) by exercising previously-untested error-handling branches, retry/backoff paths, rare CLI argument combinations, and concurrency edge cases (in-flight asset re-referencing during cleanup, shutdown/KeyboardInterrupt handling during chunked upload, cache stat() failures, etc). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FeGtMAQMVfzuD8esKux7yQ
pre-commit's black/mypy hooks flagged the new coverage test files: black needed reformatting, and mypy rejected two ClientError() calls built from plain dict literals (matching the existing type: ignore convention used elsewhere in the test suite).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raises overall coverage from 93% to 99% (cli.py, metrics.py, config.py,
path_resolver.py, and utils.py now at 100%; core.py at 98%) by exercising
previously-untested error-handling branches, retry/backoff paths, rare CLI
argument combinations, and concurrency edge cases (in-flight asset
re-referencing during cleanup, shutdown/KeyboardInterrupt handling during
chunked upload, cache stat() failures, etc).
Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01FeGtMAQMVfzuD8esKux7yQ