Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
name: ${{ matrix.name }}

steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5

- name: Install dependencies (Linux)
if: runner.os == 'Linux'
Expand All @@ -50,7 +50,7 @@ jobs:
echo "CMAKE_PREFIX_PATH=$(brew --prefix ${{ matrix.opencv }})" >> "$GITHUB_ENV"

- name: Set up Python
uses: actions/setup-python@v5
uses: actions/setup-python@v6
with:
python-version: '3.12'

Expand Down Expand Up @@ -130,6 +130,24 @@ jobs:
- name: Test (C++)
run: ctest --test-dir build --output-on-failure --no-tests=error

# ctest reports pass/fail for the binary as a whole, and
# --output-on-failure hides Catch2's summary on success -- so a green
# build records nothing about how many cases actually ran. A case that
# starts skipping stays present in --list-tests (so #65 does not catch
# it) and needs no fixture (so #63 does not either), yet exercises
# nothing. Every codec these tests need is installed above, so on CI a
# skip is a real gap rather than graceful degradation. See #66.
- name: Report and check test counts
run: |
set -o pipefail
# Default console reporter, not --reporter compact: compact omits the
# skip count entirely, so the check below would never see one.
build/framewright_tests | tail -5 | tee catch2.log
if grep -qiE "[1-9][0-9]* skipped" catch2.log; then
echo "::error::test cases were skipped; CI should run the whole suite"
exit 1
fi

- name: Test (Python)
run: |
export PYTHONPATH="$PWD/build:$PWD/python"
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ jobs:
runs-on: ubuntu-24.04
name: Build source distribution
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5

- uses: actions/setup-python@v5
- uses: actions/setup-python@v6
with:
python-version: "3.12"

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tla.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
model-check:
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5

- uses: actions/setup-java@v4
with:
Expand Down
4 changes: 4 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -37,3 +37,7 @@ _deps/
# macOS
.DS_Store
dist/

# Python
__pycache__/
*.py[cod]
Loading