Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,12 +53,28 @@ jobs:

- name: Configure
run: |
set -o pipefail
cmake -B build \
-DFRAMEWRIGHT_BUILD_TESTS=ON \
-DFRAMEWRIGHT_BUILD_EXAMPLES=ON \
-DFRAMEWRIGHT_BUILD_PYTHON=ON \
-Dpybind11_DIR=$(python3 -c "import pybind11; print(pybind11.get_cmake_dir())") \
-DCMAKE_BUILD_TYPE=Release
-DCMAKE_BUILD_TYPE=Release 2>&1 | tee configure.log

# Every test fixture is generated by ffmpeg at configure time, and the
# test cases that use them are #ifdef-guarded. A fixture that fails to
# generate therefore removes tests from the suite without failing
# anything -- the same shape of silent gap as #55, where CI ran zero
# tests and stayed green. All dependencies are installed above, so on CI
# a disabled fixture is a real problem, not a graceful degradation.
- name: Require all fixtures
run: |
if grep -q "fixture: DISABLED" configure.log; then
grep "fixture: DISABLED" configure.log
echo "::error::a test fixture failed to generate; the suite would silently shrink"
exit 1
fi
grep "fixture: enabled" configure.log

- name: Build
run: cmake --build build -j$(nproc 2>/dev/null || sysctl -n hw.ncpu)
Expand Down
3 changes: 2 additions & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -204,9 +204,10 @@ if(FRAMEWRIGHT_BUILD_TESTS)
)
if(HDR_FIXTURE_RESULT EQUAL 0)
set(HAVE_HDR_FIXTURE TRUE)
message(STATUS "HDR fixture: enabled")
else()
set(HAVE_HDR_FIXTURE FALSE)
message(STATUS "libx265 not available, HDR reader test fixture skipped")
message(STATUS "HDR fixture: DISABLED, libx265 not available")
endif()
else()
message(WARNING "ffmpeg not found, test fixtures will not be generated")
Expand Down
Loading