Repository navigation
Conversation
When camera was on, the deck's mute button was stuck in the muted state. This was caused by GetStatus() looking for the word "unmute" which was being found anytime the camera was on because of an additional control that stated "Unmuted" when the mic was on. Fixed by adding " mic" to the end of the search strings.
The InCall state was always returning True apparently because of a fallback to using ScoreTitle and anything greater than 0. This removes that fallback and changes the controls it looks for to be mic related (this could be tweaked if needed, but I think it's safe to say most meetings or calls would have a mic.) It previously using leave. hang up, & end call was keeping the mic and camera buttons from working during the meeting join window.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The InCall state was always returning True apparently because of a fallback to using ScoreTitle and anything greater than 0.
This removes that fallback and changes the controls it looks for to be mic related (this could be tweaked if needed, but I think it's safe to say most meetings or calls would have a mic.)
It previously using leave. hang up, & end call was keeping the mic and camera buttons from working during the meeting join window.