Skip to content

refactor: DCP migration, naming cleanup, and CI workflow fixes #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
klpanagi merged 11 commits into from
Jul 27, 2026
Merged

refactor: DCP migration, naming cleanup, and CI workflow fixes #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
949ef07
refactor: remove old upstream naming (prometheus, hephaestus, metis, …
klpanagi Jul 23, 2026
c0ef2e3
fix: eliminate cross-test pollution and harmonize CI workflows
klpanagi Jul 23, 2026
3c6e2cb
fix: discover plugin-registered slash commands via OpenCode SDK
klpanagi Jul 24, 2026
eda7b3b
fix: forward browserProvider to createBuiltinSkills; remove dead test…
klpanagi Jul 24, 2026
5cfa7d2
feat: replace external DCP switch script with built-in dcp_switch_pro…
klpanagi Jul 26, 2026
d0656d9
test: comprehensive tests for dcp_switch_profile tool (48 tests)
klpanagi Jul 27, 2026
d889b55
feat(dcp): migrate DCP profiles from external files to inline Zod con…
klpanagi Jul 27, 2026
ed0ecfb
fix: remove stale test references from CI workflows
klpanagi Jul 27, 2026
4248596
fix: rewrite getMessageDir cache test to use mock.module + dynamic im…
klpanagi Jul 27, 2026
7952051
fix: rewrite getMessageDir cache test to avoid mock.module for node:fs
klpanagi Jul 27, 2026
e886e9b
fix: isolate all flaky tests in both CI workflows
klpanagi Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 14 additions & 10 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,16 +63,12 @@ jobs:
# Individual files that use mock.module and cause cross-file pollution
bun test tests/tools/delegate-agent/sync-executor.test.ts
bun test tests/tools/delegate-agent/session-creator.test.ts
bun test tests/features/opencode-skill-loader/loader.test.ts
bun test tests/features/opencode-skill-loader/agents-skills-global.test.ts
bun test tests/tools/session-manager/storage.test.ts
bun test tests/hooks/prometheus-md-only/index.test.ts
bun test tests/hooks/architect/index.test.ts
bun test tests/hooks/matrix-loop/index.test.ts
bun test tests/hooks/start-work/index.test.ts
bun test tests/hooks/auto-update-checker/hook/background-update-check.test.ts
bun test tests/hooks/auto-update-checker/hook.test.ts
bun test tests/features/skill-mcp-manager/manager.test.ts
bun test tests/features/background-agent/manager.test.ts
bun test tests/hooks/comment-checker/cli.test.ts
bun test tests/hooks/comment-checker/hook.apply-patch.test.ts
Expand All @@ -82,6 +78,7 @@ jobs:
bun test tests/hooks/compaction-todo-preserver/index.test.ts
bun test tests/hooks/preemptive-compaction.test.ts
bun test tests/tools/lsp/client.test.ts
bun test tests/tools/lsp/lsp-process.test.ts
bun test tests/tools/skill/tools.test.ts
bun test tests/hooks/anthropic-context-window-limit-recovery/empty-content-recovery-sdk.test.ts
bun test tests/hooks/anthropic-context-window-limit-recovery/recovery-hook.test.ts
Expand All @@ -95,7 +92,12 @@ jobs:
bun test tests/agents/utils.test.ts
bun test tests/hooks/task-notepad/hook.test.ts
bun test tests/plugin/tool-execute-before.test.ts
bun test tests/features/mission-state/plan-storage.test.ts
bun test tests/features/mission-state/
bun test tests/features/handoff/
bun test tests/features/task-storage/
bun test tests/hooks/session-recovery/
bun test tests/plugin/session-agent-resolver.test.ts
bun test tests/hooks/auto-update-checker/checker/pinned-version-updater.test.ts

- name: Run remaining tests
run: |
Expand All @@ -108,16 +110,12 @@ jobs:
-e 'tests/features/tmux-subagent/' \
-e 'tests/tools/delegate-agent/sync-executor.test.ts' \
-e 'tests/tools/delegate-agent/session-creator.test.ts' \
-e 'tests/features/opencode-skill-loader/loader.test.ts' \
-e 'tests/features/opencode-skill-loader/agents-skills-global.test.ts' \
-e 'tests/tools/session-manager/storage.test.ts' \
-e 'tests/hooks/prometheus-md-only/index.test.ts' \
-e 'tests/hooks/architect/index.test.ts' \
-e 'tests/hooks/matrix-loop/index.test.ts' \
-e 'tests/hooks/start-work/index.test.ts' \
-e 'tests/hooks/auto-update-checker/hook/background-update-check.test.ts' \
-e 'tests/hooks/auto-update-checker/hook.test.ts' \
-e 'tests/features/skill-mcp-manager/manager.test.ts' \
-e 'tests/features/background-agent/manager.test.ts' \
-e 'tests/hooks/comment-checker/cli.test.ts' \
-e 'tests/hooks/comment-checker/hook.apply-patch.test.ts' \
Expand All @@ -127,6 +125,7 @@ jobs:
-e 'tests/hooks/compaction-todo-preserver/index.test.ts' \
-e 'tests/hooks/preemptive-compaction.test.ts' \
-e 'tests/tools/lsp/client.test.ts' \
-e 'tests/tools/lsp/lsp-process.test.ts' \
-e 'tests/tools/skill/tools.test.ts' \
-e 'tests/hooks/anthropic-context-window-limit-recovery/empty-content-recovery-sdk.test.ts' \
-e 'tests/hooks/anthropic-context-window-limit-recovery/recovery-hook.test.ts' \
Expand All @@ -137,7 +136,12 @@ jobs:
-e 'tests/tools/bdd-parse-gherkin/tools.test.ts' \
-e 'tests/tools/bdd-pipeline/pipeline-runner.test.ts' \
-e 'tests/plugin/tool-execute-before.test.ts' \
-e 'tests/features/mission-state/plan-storage.test.ts' \
-e 'tests/features/mission-state/' \
-e 'tests/features/handoff/' \
-e 'tests/features/task-storage/' \
-e 'tests/hooks/session-recovery/' \
-e 'tests/plugin/session-agent-resolver.test.ts' \
-e 'tests/hooks/auto-update-checker/checker/pinned-version-updater.test.ts' \
| xargs bun test

typecheck:
Expand Down
200 changes: 79 additions & 121 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,140 +42,98 @@ jobs:

- name: Run mock-heavy tests (isolated)
run: |
# These files use mock.module() which pollutes the module cache.
# Each runs in its own bun test invocation to prevent cross-contamination.

# --- Plugin handlers & original isolated ---
# These files use mock.module() which pollutes bun's module cache
# when run in parallel. Each invocation runs in a separate process.
#
# Directories (all test files within run together, isolated from other dirs)
bun test tests/plugin-handlers
bun test tests/hooks/compaction-context-injector
bun test tests/features/tmux-subagent
#
# Individual files that use mock.module and cause cross-file pollution
bun test tests/tools/delegate-agent/sync-executor.test.ts
bun test tests/tools/delegate-agent/session-creator.test.ts
bun test tests/features/opencode-skill-loader/loader.test.ts

# --- Hook directories that use mock.module() ---
bun test tests/hooks/architect
bun test tests/hooks/comment-checker
bun test tests/hooks/compaction-todo-preserver
bun test tests/hooks/directory-agents-injector
bun test tests/hooks/directory-readme-injector
bun test tests/hooks/prometheus-md-only
bun test tests/hooks/rules-injector

# --- Non-hook files that use mock.module() ---
bun test tests/shared/opencode-message-dir.test.ts
bun test tests/tools/session-manager/storage.test.ts
bun test tests/hooks/architect/index.test.ts
bun test tests/hooks/matrix-loop/index.test.ts
bun test tests/hooks/start-work/index.test.ts
bun test tests/hooks/auto-update-checker/hook/background-update-check.test.ts
bun test tests/hooks/auto-update-checker/hook.test.ts
bun test tests/features/background-agent/manager.test.ts
bun test tests/hooks/comment-checker/cli.test.ts
bun test tests/hooks/comment-checker/hook.apply-patch.test.ts
bun test tests/hooks/directory-agents-injector/injector.test.ts
bun test tests/hooks/directory-readme-injector/injector.test.ts
bun test tests/hooks/rules-injector/injector.test.ts
bun test tests/hooks/compaction-todo-preserver/index.test.ts
bun test tests/hooks/preemptive-compaction.test.ts
bun test tests/tools/lsp/client.test.ts
bun test tests/tools/lsp/lsp-process.test.ts
bun test tests/tools/skill/tools.test.ts
bun test tests/hooks/anthropic-context-window-limit-recovery/empty-content-recovery-sdk.test.ts
bun test tests/hooks/anthropic-context-window-limit-recovery/recovery-hook.test.ts
bun test tests/hooks/anthropic-context-window-limit-recovery/storage.test.ts
bun test tests/tools/bdd-create-contract/tools.test.ts
bun test tests/tools/bdd-parse-gherkin/tools.test.ts
bun test tests/tools/bdd-pipeline/pipeline-runner.test.ts
# spyOn() leaks from earlier tests pollute these (pass in isolation, fail
# in batch)
bun test tests/agents/utils.test.ts
bun test tests/hooks/task-notepad/hook.test.ts
bun test tests/plugin/tool-execute-before.test.ts
bun test tests/features/mission-state/plan-storage.test.ts
# OPENCODE_CONFIG_DIR env var pollution — must run isolated to prevent
# parallel test interference from other files that modify this global var
bun test tests/features/mission-state/
bun test tests/features/handoff/
bun test tests/features/task-storage/
bun test tests/hooks/session-recovery/
bun test tests/plugin/session-agent-resolver.test.ts
bun test tests/hooks/auto-update-checker/checker/pinned-version-updater.test.ts
bun test tests/shared/opencode-message-dir.test.ts

- name: Run remaining tests
run: |
# Only pure (non-mock.module) test files/dirs run together here.
# Excluded: mock.module files (run isolated above), pre-existing failures.
# Pre-existing failures excluded:
# src/shared/model-requirements.test.ts (stale model expectations)
# src/hooks/anthropic-context-window-limit-recovery (CI-only failures, bun version)
# src/hooks/todo-continuation-enforcer (7 fail)
# src/hooks/auto-update-checker (4 fail)
# src/hooks/context-window-monitor.test.ts (2 fail)
# src/hooks/preemptive-compaction.test.ts (3 fail)
# src/agents/utils.test.ts (CI-only failures: stale model expectations after merovingian model refactor; passes locally)
bun test tests/config tests/mcp tests/index.test.ts \
tests/agents/builtin-agents/resolve-file-uri.test.ts \
tests/agents/cipher.test.ts \
tests/agents/dynamic-agent-prompt-builder.test.ts \
tests/agents/momus.test.ts \
tests/agents/mouse/index.test.ts \
tests/agents/oracle-prompt.test.ts \
tests/agents/types.test.ts \
tests/shared/agent-config-integration.test.ts \
tests/shared/agent-display-names.test.ts \
tests/shared/agent-variant.test.ts \
tests/shared/connected-providers-cache.test.ts \
tests/shared/deep-merge.test.ts \
tests/shared/external-plugin-detector.test.ts \
tests/shared/file-utils.test.ts \
tests/shared/first-message-variant.test.ts \
tests/shared/frontmatter.test.ts \
tests/shared/git-worktree \
tests/shared/jsonc-parser.test.ts \
tests/shared/merge-categories.test.ts \
tests/shared/migration.test.ts \
tests/shared/model-availability.test.ts \
tests/shared/model-resolver.test.ts \
tests/shared/model-suggestion-retry.test.ts \
tests/shared/normalize-sdk-response.test.ts \
tests/shared/opencode-config-dir.test.ts \
tests/shared/opencode-http-api.test.ts \
tests/shared/opencode-server-auth.test.ts \
tests/shared/opencode-storage-detection.test.ts \
tests/shared/opencode-version.test.ts \
tests/shared/permission-compat.test.ts \
tests/shared/port-utils.test.ts \
tests/shared/safe-create-hook.test.ts \
tests/shared/session-cursor.test.ts \
tests/shared/session-directory-resolver.test.ts \
tests/shared/session-tools-store.test.ts \
tests/shared/skill-path-resolver.test.ts \
tests/shared/system-directive.test.ts \
tests/shared/tmux \
tests/shared/truncate-description.test.ts \
tests/tools/ast-grep tests/tools/background-task tests/tools/delegate-task \
tests/tools/glob tests/tools/grep tests/tools/hashline-edit tests/tools/interactive-bash \
tests/tools/look-at \
tests/tools/lsp/lsp-process.test.ts \
tests/tools/lsp/server-config-loader.test.ts \
tests/tools/lsp/utils.test.ts \
tests/tools/lsp/config.test.ts \
tests/tools/session-manager/tools.test.ts \
tests/tools/session-manager/utils.test.ts \
tests/tools/skill-mcp tests/tools/slashcommand tests/tools/task \
tests/tools/delegate-agent/background-agent-executor.test.ts \
tests/tools/delegate-agent/background-executor.test.ts \
tests/tools/delegate-agent/subagent-session-creator.test.ts \
tests/hooks/anthropic-effort \
tests/hooks/auto-slash-command \
tests/hooks/category-skill-reminder \
tests/hooks/delegate-task-retry \
tests/hooks/edit-error-recovery \
tests/hooks/env-file-write-guard \
tests/hooks/handoff-injector \
tests/hooks/hashline-read-enhancer \
tests/hooks/keyword-detector \
tests/hooks/matrix-loop \
tests/hooks/non-interactive-env \
tests/hooks/question-label-truncator \
tests/hooks/secret-leak-guard \
tests/hooks/session-recovery \
tests/hooks/start-work \
tests/hooks/stop-continuation-guard \
tests/hooks/task-reminder \
tests/hooks/task-resume-info \
tests/hooks/tasks-todowrite-disabler \
tests/hooks/think-mode \
tests/hooks/unstable-agent-babysitter \
tests/hooks/write-existing-file-guard \
tests/hooks/session-notification.test.ts \
tests/hooks/tool-output-truncator.test.ts \
tests/features/background-agent/manager.polling.test.ts \
tests/features/background-agent/task-poller.test.ts \
tests/features/background-agent/parent-session-notifier.test.ts \
tests/features/background-agent/concurrency.test.ts \
tests/features/background-agent/task-history.test.ts \
tests/features/builtin-commands \
tests/features/builtin-skills \
tests/features/session-state \
tests/features/hook-message-injector \
tests/features/opencode-skill-loader/config-source-discovery.test.ts \
tests/features/opencode-skill-loader/merger.test.ts \
tests/features/opencode-skill-loader/skill-content.test.ts \
tests/features/opencode-skill-loader/blocking.test.ts \
tests/features/skill-mcp-manager/env-cleaner.test.ts
# Run all other tests together. The mock-heavy files above are excluded
# via --exclude patterns to prevent double-running and pollution.
find tests script -name '*.test.ts' -type f \
| grep -v -F \
-e 'tests/plugin-handlers/' \
-e 'tests/hooks/compaction-context-injector/' \
-e 'tests/features/tmux-subagent/' \
-e 'tests/tools/delegate-agent/sync-executor.test.ts' \
-e 'tests/tools/delegate-agent/session-creator.test.ts' \
-e 'tests/tools/session-manager/storage.test.ts' \
-e 'tests/hooks/architect/index.test.ts' \
-e 'tests/hooks/matrix-loop/index.test.ts' \
-e 'tests/hooks/start-work/index.test.ts' \
-e 'tests/hooks/auto-update-checker/hook/background-update-check.test.ts' \
-e 'tests/hooks/auto-update-checker/hook.test.ts' \
-e 'tests/features/background-agent/manager.test.ts' \
-e 'tests/hooks/comment-checker/cli.test.ts' \
-e 'tests/hooks/comment-checker/hook.apply-patch.test.ts' \
-e 'tests/hooks/directory-agents-injector/injector.test.ts' \
-e 'tests/hooks/directory-readme-injector/injector.test.ts' \
-e 'tests/hooks/rules-injector/injector.test.ts' \
-e 'tests/hooks/compaction-todo-preserver/index.test.ts' \
-e 'tests/hooks/preemptive-compaction.test.ts' \
-e 'tests/tools/lsp/client.test.ts' \
-e 'tests/tools/lsp/lsp-process.test.ts' \
-e 'tests/tools/skill/tools.test.ts' \
-e 'tests/hooks/anthropic-context-window-limit-recovery/empty-content-recovery-sdk.test.ts' \
-e 'tests/hooks/anthropic-context-window-limit-recovery/recovery-hook.test.ts' \
-e 'tests/hooks/anthropic-context-window-limit-recovery/storage.test.ts' \
-e 'tests/agents/utils.test.ts' \
-e 'tests/hooks/task-notepad/hook.test.ts' \
-e 'tests/tools/bdd-create-contract/tools.test.ts' \
-e 'tests/tools/bdd-parse-gherkin/tools.test.ts' \
-e 'tests/tools/bdd-pipeline/pipeline-runner.test.ts' \
-e 'tests/plugin/tool-execute-before.test.ts' \
-e 'tests/features/mission-state/' \
-e 'tests/features/handoff/' \
-e 'tests/features/task-storage/' \
-e 'tests/hooks/session-recovery/' \
-e 'tests/plugin/session-agent-resolver.test.ts' \
-e 'tests/hooks/auto-update-checker/checker/pinned-version-updater.test.ts' \
-e 'tests/shared/opencode-message-dir.test.ts' \
| xargs bun test

typecheck:
runs-on: ubuntu-latest
Expand Down
6 changes: 6 additions & 0 deletions .opencode/opencode.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"$schema": "https://opencode.ai/config.json",
"plugin": [
"list"
]
}
9 changes: 4 additions & 5 deletions AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ matrixx/
│ ├── agents/ → 14 agents (incl. Sati, Cipher, Sentinel) + AGENTS.md
│ ├── hooks/ → ~52 hooks in 3 tiers
│ ├── tools/ → 16 dirs (LSP, AST-grep, delegate-task, session, handoff, glob, grep, look-at, delegate-agent, background-task, interactive-bash, hashline-edit, skill, skill-mcp, slashcommand, task)
│ ├── features/ → 20 dirs (background-agent, skills, commands, tasks, tmux, MCP, oauth, handoff, CC compat)
│ ├── features/ → 19 dirs (background-agent, skills, commands, tasks, tmux, handoff, CC compat)
│ ├── shared/ → 80+ utilities
│ ├── mcp/ → 4 built-in MCPs (websearch, context7, grep_app, document-reader)
│ ├── cli/ → CLI installer, doctor, config-manager
Expand Down Expand Up @@ -309,11 +309,10 @@ For full model/temp/fallback details see the per-agent file or `src/agents/AGENT
- JSONC: comments + trailing commas via `jsonc-parser` (use `src/shared/jsonc-parser.ts`, not raw `JSON.parse`)
- Legacy config auto-migrated by `src/shared/migration/` (agent names, hook names, model versions)

## MCP ARCHITECTURE (3 tiers)
## MCP ARCHITECTURE (2 tiers)

1. **Built-in** (`src/mcp/`): websearch (Exa/Tavily), context7, grep_app, document-reader
2. **Claude Code compat** (`features/claude-code-mcp-loader/`): `.mcp.json` with `${VAR}` expansion
3. **Skill-embedded** (`features/opencode-skill-loader/`): YAML frontmatter in `SKILL.md`
1. **Built-in** (`src/mcp/`): websearch, context7, grep_app, document-reader
2. **Plugin-config / user-configured**: MCPs defined in plugin configuration

## KNOWN HOTSPOTS (largest files)

Expand Down
Loading
Loading