This repository was archived by the owner on Dec 18, 2019. It is now read-only.
Shared password bug-fix#6
Open
claudiouzelac wants to merge 2 commits into
Open
Conversation
Owner
|
Wouldn't it be better to just filter out that column and not exclude the row all together? The other data could still be exported even if one column has no data. |
| console.log( i + "\t"+addSpaces(30,title_fill.value) + addSpaces(30,username_fill.value) + password_fill.value); // print item to see progress | ||
| result.push( [ url_fill.value, title_fill.value, username_fill.value, "" , password_fill.value,"" , memo_fill.value ]); // add values to results array to be converted into csv file. Empty values should be empty strings, don't use null or leave blank | ||
| if(typeof memo_fill != 'undefined') { | ||
| result.push( [ url_fill.value, title_fill.value, username_fill.value, "" , password_fill.value,"" , memo_fill.value ]); // add values to results array to be converted into csv file. Empty values should be empty strings, don't use null or leave blank |
Owner
There was a problem hiding this comment.
result.push( [ url_fill.value, title_fill.value, username_fill.value, "" , password_fill.value,"" , memo_fill ? memo_fill.value : '' ]);
something like this?
Author
There was a problem hiding this comment.
Good point, a better implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shared passwords in PasswordBox don't expose the memo field. This patch seeks to provide support for that case.
This change is