Skip to content

fix(install): clean exit from install.sh (cleanup trap under set -u) #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kldzj merged 1 commit into from
Jun 30, 2026
Merged

fix(install): clean exit from install.sh (cleanup trap under set -u) #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,9 @@ sha256_of() {
}

main() {
local target os arch tag asset base tmp sudo expected actual
# tmp is intentionally NOT local: the EXIT trap below runs in global scope and
# must still see it (otherwise `set -u` trips on cleanup after a successful run).
local target os arch tag asset base sudo expected actual
target="${1:-$DEFAULT_TARGET}"
os="$(detect_os)"
arch="$(detect_arch)"
Expand All @@ -67,7 +69,7 @@ main() {
info "Installing pzmod ${tag} (${os}/${arch}) to ${target}"

tmp="$(mktemp -d)"
trap 'rm -rf "$tmp"' EXIT
trap 'rm -rf "${tmp:-}"' EXIT

curl -fSL --proto '=https' --tlsv1.2 -o "$tmp/pzmod" "${base}/${asset}" \
|| err "no prebuilt binary for ${asset} in ${tag} (see ${base})"
Expand Down
Loading